Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 134043004: Update page & frame classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, kenneth.christiansen, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update page & frame classes to use OVERRIDE / FINAL when needed Update page & frame classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=esprehn, abarth BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -101 lines) Patch
M Source/core/frame/Console.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/DOMSecurityPolicy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/DOMTimer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/DOMWindow.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleNotifier.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.h View 15 chunks +34 lines, -34 lines 0 comments Download
M Source/core/frame/History.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/ImageBitmap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/Location.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Navigator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Screen.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/SuspendableTimer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/frame/animation/ImplicitAnimation.h View 3 chunks +11 lines, -11 lines 0 comments Download
M Source/core/frame/animation/KeyframeAnimation.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/page/Chrome.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/DOMSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DOMWindowPagePopup.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/EventSource.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/page/Page.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/PageLifecycleNotifier.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingConstraints.h View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-10 21:24:44 UTC) #1
eseidel
lgtm
6 years, 11 months ago (2014-01-10 21:55:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/134043004/1
6 years, 11 months ago (2014-01-10 21:55:31 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 22:04:31 UTC) #4
Message was sent while issue was closed. 
Change committed as 164908

Powered by Google App Engine
This is Rietveld 408576698