Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: Source/core/page/scrolling/ScrollingConstraints.h

Issue 134043004: Update page & frame classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/PageLifecycleNotifier.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/scrolling/ScrollingConstraints.h
diff --git a/Source/core/page/scrolling/ScrollingConstraints.h b/Source/core/page/scrolling/ScrollingConstraints.h
index 993f2340734a7202ec5e5c7661f119f2fae15485..857430e5a63329e25919cfb16ecc2eccc10e9a69 100644
--- a/Source/core/page/scrolling/ScrollingConstraints.h
+++ b/Source/core/page/scrolling/ScrollingConstraints.h
@@ -73,7 +73,7 @@ protected:
AnchorEdges m_anchorEdges;
};
-class FixedPositionViewportConstraints : public ViewportConstraints {
+class FixedPositionViewportConstraints FINAL : public ViewportConstraints {
public:
FixedPositionViewportConstraints()
: ViewportConstraints()
@@ -104,13 +104,13 @@ public:
bool operator!=(const FixedPositionViewportConstraints& other) const { return !(*this == other); }
private:
- virtual ConstraintType constraintType() const OVERRIDE { return FixedPositionConstaint; };
+ virtual ConstraintType constraintType() const OVERRIDE { return FixedPositionConstaint; }
FloatRect m_viewportRectAtLastLayout;
FloatPoint m_layerPositionAtLastLayout;
};
-class StickyPositionViewportConstraints : public ViewportConstraints {
+class StickyPositionViewportConstraints FINAL : public ViewportConstraints {
public:
StickyPositionViewportConstraints()
: m_leftOffset(0)
@@ -172,7 +172,7 @@ public:
bool operator!=(const StickyPositionViewportConstraints& other) const { return !(*this == other); }
private:
- virtual ConstraintType constraintType() const OVERRIDE { return StickyPositionConstraint; };
+ virtual ConstraintType constraintType() const OVERRIDE { return StickyPositionConstraint; }
float m_leftOffset;
float m_rightOffset;
« no previous file with comments | « Source/core/page/PageLifecycleNotifier.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698