Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Unified Diff: Source/core/page/Page.h

Issue 134043004: Update page & frame classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/EventSource.h ('k') | Source/core/page/PageLifecycleNotifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/Page.h
diff --git a/Source/core/page/Page.h b/Source/core/page/Page.h
index 80c32355398f398ac20bf5ae023cf6bc230b1b39..330c8250a66f3b63cf1b7b48da299c9206259259 100644
--- a/Source/core/page/Page.h
+++ b/Source/core/page/Page.h
@@ -82,7 +82,7 @@ typedef uint64_t LinkHash;
float deviceScaleFactor(Frame*);
-class Page : public Supplementable<Page>, public LifecycleContext<Page>, public SettingsDelegate {
+class Page FINAL : public Supplementable<Page>, public LifecycleContext<Page>, public SettingsDelegate {
WTF_MAKE_NONCOPYABLE(Page);
friend class Settings;
public:
@@ -105,7 +105,7 @@ public:
};
explicit Page(PageClients&);
- ~Page();
+ virtual ~Page();
FrameHost& frameHost() { return *m_frameHost; }
« no previous file with comments | « Source/core/page/EventSource.h ('k') | Source/core/page/PageLifecycleNotifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698