Issue 1339793002: win xp: Don't use ICU_REJECT_USERPWD with WinHttpCrackUrl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1339793002: win xp: Don't use ICU_REJECT_USERPWD with WinHttpCrackUrl (Closed)

Created:
5 years, 3 months ago by scottmg

Modified:
5 years, 3 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@xp-all-access

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

win xp: Don't use ICU_REJECT_USERPWD with WinHttpCrackUrl Fails on XP with ERROR_INVALID_PARAMETER (undocumented). Not overly important that we reject embedded user/passwords in the URL for this use case. R=mark@chromium.org BUG=crashpad:50 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/ccf9f9851987be0c7eec079cdff197af3affd0f1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	util/net/http_transport_win.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Depends on Patchset:

Total messages: 4 (0 generated)

Mark Mentovai

LGTM I was going to suggest making this conditional at runtime on OS version, but ...

5 years, 3 months ago (2015-09-11 20:21:55 UTC) #2

scottmg

On 2015/09/11 20:21:55, Mark Mentovai - August is over wrote: > LGTM > > I ...

5 years, 3 months ago (2015-09-11 20:23:10 UTC) #3

scottmg

5 years, 3 months ago (2015-09-11 20:24:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ccf9f9851987be0c7eec079cdff197af3affd0f1 (presubmit successful).