win: Fix OpenProcess(PROCESS_ALL_ACCESS, ...) on XP

win: Fix OpenProcess(PROCESS_ALL_ACCESS, ...) on XP

PROCESS_ALL_ACCESS was changed in later SDKs and the newer value fails
when run on XP with ERROR_ACCESS_DENIED. Use the old value to maintain
compatibility with XP.

R=mark@chromium.org
BUG=crashpad:50
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/3a886267aaf055db86030723cb568acb88915190

[Mark Mentovai, 2015-09-11 20:03:27]

LGTM

https://codereview.chromium.org/1337133002/diff/60001/util/win/xp_compat.h
File util/win/xp_compat.h (right):

https://codereview.chromium.org/1337133002/diff/60001/util/win/xp_compat.h#ne...
util/win/xp_compat.h:22: //! \brief This is the XP-suitable value of
PROCESS_ALL_ACCESS.
`PROCESS_ALL_ACCESS`

Not sure if this makes more sense in the generated documentation if it’s inside
the enum, or if Doxygen understands the single-item enum idiom for constants.

https://codereview.chromium.org/1337133002/diff/60001/util/win/xp_compat.h#ne...
util/win/xp_compat.h:27: enum { kXPProcessAllAccess = STANDARD_RIGHTS_REQUIRED |
SYNCHRONIZE | 0xFFF };
I think the answer is no, but do we lose anything by not having 0xf000 set on
systems that support it? The only bits that adds that I see defined in the SDK
are PROCESS_{QUERY,SET}_LIMITED_INFORMATION, but you should have that sort of
access with PROCESS_{QUERY,SET}_INFORMATION which is included in
kXPProcessAllAccess.

[scottmg, 2015-09-11 20:14:29]

https://codereview.chromium.org/1337133002/diff/60001/util/win/xp_compat.h
File util/win/xp_compat.h (right):

https://codereview.chromium.org/1337133002/diff/60001/util/win/xp_compat.h#ne...
util/win/xp_compat.h:22: //! \brief This is the XP-suitable value of
PROCESS_ALL_ACCESS.
On 2015/09/11 20:03:27, Mark Mentovai - August is over wrote:
> `PROCESS_ALL_ACCESS`
> 
> Not sure if this makes more sense in the generated documentation if it’s
inside
> the enum, or if Doxygen understands the single-item enum idiom for constants.

Done and moved inside.

https://codereview.chromium.org/1337133002/diff/60001/util/win/xp_compat.h#ne...
util/win/xp_compat.h:27: enum { kXPProcessAllAccess = STANDARD_RIGHTS_REQUIRED |
SYNCHRONIZE | 0xFFF };
On 2015/09/11 20:03:27, Mark Mentovai - August is over wrote:
> I think the answer is no, but do we lose anything by not having 0xf000 set on
> systems that support it? The only bits that adds that I see defined in the SDK
> are PROCESS_{QUERY,SET}_LIMITED_INFORMATION, but you should have that sort of
> access with PROCESS_{QUERY,SET}_INFORMATION which is included in
> kXPProcessAllAccess.

That was my understanding too. I guess as long as the tests are OK, we should be
fine in any case.

[scottmg, 2015-09-11 20:16:12]

Committed patchset #5 (id:80001) manually as
3a886267aaf055db86030723cb568acb88915190 (presubmit successful).