Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: util/net/http_transport_win.cc

Issue 1339793002: win xp: Don't use ICU_REJECT_USERPWD with WinHttpCrackUrl (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@xp-all-access
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/net/http_transport_win.cc
diff --git a/util/net/http_transport_win.cc b/util/net/http_transport_win.cc
index 1fa1810b7e0091d08079d2f98c5515d13c22bb40..e053311d440af292b7a4b62536fd063cbff77423 100644
--- a/util/net/http_transport_win.cc
+++ b/util/net/http_transport_win.cc
@@ -114,8 +114,10 @@ bool HTTPTransportWin::ExecuteSynchronously(std::string* response_body) {
url_components.dwUrlPathLength = 1;
url_components.dwExtraInfoLength = 1;
std::wstring url_wide(base::UTF8ToUTF16(url()));
+ // dwFlags = ICU_REJECT_USERPWD fails on XP. See "Community Additions" at:
+ // https://msdn.microsoft.com/en-us/library/aa384092.aspx
if (!WinHttpCrackUrl(
- url_wide.c_str(), 0, ICU_REJECT_USERPWD, &url_components)) {
+ url_wide.c_str(), 0, 0, &url_components)) {
LogErrorWinHttpMessage("WinHttpCrackUrl");
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698