win xp: Don't use ICU_REJECT_USERPWD with WinHttpCrackUrl

util/net/http_transport_win.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 96 matching lines @@
     LogErrorWinHttpMessage("WinHttpSetTimeouts");
     return false;
   }
 
   URL_COMPONENTS url_components = {0};
   url_components.dwStructSize = sizeof(URL_COMPONENTS);
   url_components.dwHostNameLength = 1;
   url_components.dwUrlPathLength = 1;
   url_components.dwExtraInfoLength = 1;
   std::wstring url_wide(base::UTF8ToUTF16(url()));
+  // dwFlags = ICU_REJECT_USERPWD fails on XP. See "Community Additions" at:
+  // https://msdn.microsoft.com/en-us/library/aa384092.aspx
   if (!WinHttpCrackUrl(
-          url_wide.c_str(), 0, ICU_REJECT_USERPWD, &url_components)) {
+          url_wide.c_str(), 0, 0, &url_components)) {
     LogErrorWinHttpMessage("WinHttpCrackUrl");
     return false;
   }
   DCHECK(url_components.nScheme == INTERNET_SCHEME_HTTP ||
          url_components.nScheme == INTERNET_SCHEME_HTTPS);
   std::wstring host_name(url_components.lpszHostName,
                          url_components.dwHostNameLength);
   std::wstring url_path(url_components.lpszUrlPath,
                         url_components.dwUrlPathLength);
   std::wstring extra_info(url_components.lpszExtraInfo,
@@ skipping 109 matching lines @@
 }
 
 }  // namespace
 
 // static
 scoped_ptr<HTTPTransport> HTTPTransport::Create() {
   return scoped_ptr<HTTPTransportWin>(new HTTPTransportWin);
 }
 
 }  // namespace crashpad