components/autofill/core/browser/autofill_manager.h - Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/autofill/core/browser/autofill_external_delegate_unittest.cc ('k') | components/autofill/core/browser/autofill_manager.cc » ('j') | components/autofill/core/browser/password_autofill_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.h

diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h

index 735f18a29950f957c013e2a364f46ba2c6428880..c9e5c8af9f5dc3803a7e4bc9972b07ffbda9ee5a 100644

--- a/components/autofill/core/browser/autofill_manager.h

+++ b/components/autofill/core/browser/autofill_manager.h

@@ -26,6 +26,7 @@

#include "components/autofill/core/browser/personal_data_manager.h"

#include "components/autofill/core/common/form_data.h"

#include "components/autofill/core/common/forms_seen_state.h"

+#include "components/autofill/core/common/password_form.h"

#include "third_party/WebKit/public/web/WebFormElement.h"

class GURL;

@@ -135,6 +136,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {

void OnQueryFormFieldAutofill(int query_id,

const FormData& form,

const FormFieldData& field,

+ const PasswordForm& password_form,

const gfx::RectF& bounding_box,

bool display_warning);

void OnDidEndTextFieldEditing();

@@ -142,11 +144,11 @@ class AutofillManager : public AutofillDownloadManager::Observer {

void OnAddPasswordFormMapping(

const FormFieldData& form,

const PasswordFormFillData& fill_data);

- void OnShowPasswordSuggestions(

- const FormFieldData& field,

- const gfx::RectF& bounds,

- const std::vector<base::string16>& suggestions,

- const std::vector<base::string16>& realms);

+ void OnShowPasswordSuggestions(const FormFieldData& field,

+ const PasswordForm& password_form,

+ const gfx::RectF& bounds,

+ const std::vector<base::string16>& suggestions,

+ const std::vector<base::string16>& realms);

void OnSetDataList(const std::vector<base::string16>& values,

const std::vector<base::string16>& labels);