Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: components/autofill/core/browser/autofill_external_delegate_unittest.cc

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_external_delegate_unittest.cc
diff --git a/components/autofill/core/browser/autofill_external_delegate_unittest.cc b/components/autofill/core/browser/autofill_external_delegate_unittest.cc
index fe0f6f712747a02e90f9a81c4158466ea234d1e0..d1e2ce4958f8d64e7cff86707d937a10801d059f 100644
--- a/components/autofill/core/browser/autofill_external_delegate_unittest.cc
+++ b/components/autofill/core/browser/autofill_external_delegate_unittest.cc
@@ -129,9 +129,11 @@ class AutofillExternalDelegateUnitTest
FormFieldData field;
field.is_focusable = true;
field.should_autocomplete = true;
+ PasswordForm password_form;
const gfx::RectF element_bounds;
- external_delegate_->OnQuery(query_id, form, field, element_bounds, true);
+ external_delegate_->OnQuery(
+ query_id, form, field, password_form, element_bounds, true);
}
MockAutofillManagerDelegate manager_delegate_;
@@ -325,9 +327,11 @@ TEST_F(AutofillExternalDelegateUnitTest, NoAutofillWarningsWithoutSuggestions) {
FormFieldData field;
field.is_focusable = true;
field.should_autocomplete = false;
+ PasswordForm password_form;
const gfx::RectF element_bounds;
- external_delegate_->OnQuery(kQueryId, form, field, element_bounds, true);
+ external_delegate_->OnQuery(
+ kQueryId, form, password_form, field, element_bounds, true);
EXPECT_CALL(manager_delegate_,
ShowAutofillPopup(_, _, _, _, _, _, _)).Times(0);
@@ -421,10 +425,9 @@ TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegatePasswordSuggestions) {
WebAutofillClient::MenuItemIDPasswordEntry)),
_));
- external_delegate_->OnShowPasswordSuggestions(suggestions,
- realms,
- field,
- element_bounds);
+ PasswordForm password_form;
+ external_delegate_->OnShowPasswordSuggestions(
+ suggestions, realms, field, password_form, element_bounds);
EXPECT_CALL(manager_delegate_, HideAutofillPopup());
@@ -464,9 +467,11 @@ TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateHideWarning) {
FormFieldData field;
field.is_focusable = true;
field.should_autocomplete = false;
+ PasswordForm password_form;
const gfx::RectF element_bounds;
- external_delegate_->OnQuery(kQueryId, form, field, element_bounds, false);
+ external_delegate_->OnQuery(
+ kQueryId, form, field, password_form, element_bounds, false);
std::vector<base::string16> autofill_items;
autofill_items.push_back(base::string16());

Powered by Google App Engine
This is Rietveld 408576698