Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 22ec8be61893c33aa0bae1a85613c3fa0eeaf2ea..e2489a91efe6f921304a1514706fb25efd05f652 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -354,21 +354,20 @@ void AutofillManager::OnTextFieldDidChange(const FormData& form,
UpdateInitialInteractionTimestamp(timestamp);
}
-void AutofillManager::OnQueryFormFieldAutofill(int query_id,
- const FormData& form,
- const FormFieldData& field,
- const gfx::RectF& bounding_box,
- bool display_warning) {
+void AutofillManager::OnQueryFormFieldAutofill(
+ int query_id,
+ const FormData& form,
+ const FormFieldData& field,
+ const PasswordForm& password_form,
+ const gfx::RectF& bounding_box,
+ bool display_warning) {
std::vector<base::string16> values;
std::vector<base::string16> labels;
std::vector<base::string16> icons;
std::vector<int> unique_ids;
- external_delegate_->OnQuery(query_id,
- form,
- field,
- bounding_box,
- display_warning);
+ external_delegate_->OnQuery(
+ query_id, form, field, password_form, bounding_box, display_warning);
RenderViewHost* host = NULL;
FormStructure* form_structure = NULL;
@@ -612,13 +611,12 @@ void AutofillManager::OnAddPasswordFormMapping(
void AutofillManager::OnShowPasswordSuggestions(
const FormFieldData& field,
+ const PasswordForm& password_form,
const gfx::RectF& bounds,
const std::vector<base::string16>& suggestions,
const std::vector<base::string16>& realms) {
- external_delegate_->OnShowPasswordSuggestions(suggestions,
- realms,
- field,
- bounds);
+ external_delegate_->OnShowPasswordSuggestions(
+ suggestions, realms, field, password_form, bounds);
}
void AutofillManager::OnSetDataList(const std::vector<base::string16>& values,

Powered by Google App Engine
This is Rietveld 408576698