components/autofill/content/renderer/password_autofill_agent.cc - Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/autofill_agent.cc ('K') | « components/autofill/content/renderer/autofill_agent.cc ('k') | components/autofill/core/browser/autofill_external_delegate.h » ('j') | components/autofill/core/browser/password_autofill_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.cc

diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc

index d59aeefe9761283cca12ef84d1080f9a578a23ac..ce74fe39d010728613061f586c34a9f7c94c85bf 100644

--- a/components/autofill/content/renderer/password_autofill_agent.cc

+++ b/components/autofill/content/renderer/password_autofill_agent.cc

@@ -612,6 +612,10 @@ bool PasswordAutofillAgent::ShowSuggestionPopup(

FindFormAndFieldForInputElement(

user_input, &form, &field, REQUIRE_NONE);

+ scoped_ptr<PasswordForm> password_form =

+ CreatePasswordForm(user_input.form());

+ DCHECK(password_form.get());

vabr (Chromium) 2014/01/14 15:01:21 Also here, .get() is not necessary.

riadh.chtara 2014/01/17 08:25:08 Done.

blink::WebInputElement selected_element = user_input;

gfx::Rect bounding_box(selected_element.boundsInViewportSpace());

@@ -622,6 +626,7 @@ bool PasswordAutofillAgent::ShowSuggestionPopup(

bounding_box.height() * scale);

Send(new AutofillHostMsg_ShowPasswordSuggestions(routing_id(),

field,

+ *password_form,

bounding_box_scaled,

suggestions,

realms));