components/autofill/core/browser/autofill_manager_unittest.cc - Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager_unittest.cc

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/autofill/core/browser/autofill_manager.cc ('k') | components/autofill/core/browser/autofill_metrics_unittest.cc » ('j') | components/autofill/core/browser/password_autofill_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager_unittest.cc

diff --git a/components/autofill/core/browser/autofill_manager_unittest.cc b/components/autofill/core/browser/autofill_manager_unittest.cc

index 138f7d4ab9531e4ab13017050c9c129c0d5ff221..66bdf61bc034e1e77205a6fbe720419299c09d76 100644

--- a/components/autofill/core/browser/autofill_manager_unittest.cc

+++ b/components/autofill/core/browser/autofill_manager_unittest.cc

@@ -41,6 +41,7 @@

#include "components/autofill/core/common/form_data.h"

#include "components/autofill/core/common/form_field_data.h"

#include "components/autofill/core/common/forms_seen_state.h"

+#include "components/autofill/core/common/password_form.h"

#include "components/user_prefs/user_prefs.h"

#include "content/public/browser/web_contents.h"

#include "content/public/test/mock_render_process_host.h"

@@ -543,6 +544,7 @@ class TestAutofillExternalDelegate : public AutofillExternalDelegate {

virtual void OnQuery(int query_id,

const FormData& form,

const FormFieldData& field,

+ const PasswordForm& password_form,

const gfx::RectF& bounds,

bool display_warning) OVERRIDE {

on_query_seen_ = true;

@@ -659,11 +661,9 @@ class AutofillManagerTest : public ChromeRenderViewHostTestHarness {

void GetAutofillSuggestions(int query_id,

const FormData& form,

const FormFieldData& field) {

- autofill_manager_->OnQueryFormFieldAutofill(query_id,

- form,

- field,

- gfx::Rect(),

- false);

+ PasswordForm password_form;

+ autofill_manager_->OnQueryFormFieldAutofill(

+ query_id, form, field, password_form, gfx::Rect(), false);

}

void GetAutofillSuggestions(const FormData& form,