Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1338333002: Add checks for android printing (Closed)

Created:
5 years, 3 months ago by dgn
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add checks for android printing Adds a null check for the WebContent used to set up renderer initiated print jobs and some warnings to be able to follow failures in the process. BUG=528909 Committed: https://crrev.com/e94f112042eba6eff2cf2fb10f853103a50f63b2 Cr-Commit-Position: refs/heads/master@{#349121}

Patch Set 1 #

Patch Set 2 : More logs, moved existing ones to debug #

Patch Set 3 : Add test #

Patch Set 4 : Updated test. It still is kind of flaky (2/30, the print dialog comes up -> timeout), but no crash #

Messages

Total messages: 13 (4 generated)
dgn
PTAL
5 years, 3 months ago (2015-09-14 19:20:03 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 3 months ago (2015-09-15 00:10:13 UTC) #3
dgn
bauerb@chromium.org: Please review changes in chrome/android/java/src/org/chromium/chrome/browser/printing/TabPrinter.java
5 years, 3 months ago (2015-09-15 09:44:48 UTC) #5
Bernhard Bauer
lgtm
5 years, 3 months ago (2015-09-15 10:56:01 UTC) #6
dgn
Passes now. Thanks for the review!
5 years, 3 months ago (2015-09-16 14:27:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338333002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338333002/60001
5 years, 3 months ago (2015-09-16 14:28:21 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-16 14:34:26 UTC) #11
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/e94f112042eba6eff2cf2fb10f853103a50f63b2 Cr-Commit-Position: refs/heads/master@{#349121}
5 years, 3 months ago (2015-09-16 14:35:04 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:55:38 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e94f112042eba6eff2cf2fb10f853103a50f63b2
Cr-Commit-Position: refs/heads/master@{#349121}

Powered by Google App Engine
This is Rietveld 408576698