Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3029)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/printing/TabPrinter.java

Issue 1338333002: Add checks for android printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated test. It still is kind of flaky (2/30, the print dialog comes up -> timeout), but no crash Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/printing/TabPrinter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/printing/TabPrinter.java b/chrome/android/java/src/org/chromium/chrome/browser/printing/TabPrinter.java
index 94d084997c202a664edbe39288961dd2b40509fd..d8644a61b1f1368cb07727297dda7d63b582f405 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/printing/TabPrinter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/printing/TabPrinter.java
@@ -6,6 +6,7 @@
import android.text.TextUtils;
+import org.chromium.base.Log;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.printing.Printable;
@@ -19,6 +20,7 @@
*/
public class TabPrinter implements Printable {
private static String sDefaultTitle;
+ private static final String TAG = "cr.printing";
private final WeakReference<Tab> mTab;
@@ -33,7 +35,11 @@ public static void setDefaultTitle(String defaultTitle) {
@Override
public boolean print() {
Tab tab = mTab.get();
- return tab != null && tab.isInitialized() && tab.print();
+ if (tab == null || !tab.isInitialized()) {
+ Log.d(TAG, "Tab not ready, unable to start printing.");
+ return false;
+ }
+ return tab.print();
}
@Override
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698