chrome/browser/printing/print_job_worker.cc - Issue 1338333002: Add checks for android printing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_job_worker.cc

Issue 1338333002: Add checks for android printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated test. It still is kind of flaky (2/30, the print dialog comes up -> timeout), but no crash Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/print_job_worker.cc

diff --git a/chrome/browser/printing/print_job_worker.cc b/chrome/browser/printing/print_job_worker.cc

index 97ef340dcb9a891077befbe15d9f10209712ca40..4648e1f594746184437c02166f54e4db0bf39731 100644

--- a/chrome/browser/printing/print_job_worker.cc

+++ b/chrome/browser/printing/print_job_worker.cc

@@ -219,7 +219,8 @@ void PrintJobWorker::GetSettingsWithUI(

static_cast<PrintingContextDelegate*>(printing_context_delegate_.get());

content::WebContents* web_contents =

printing_context_delegate->GetWebContents();

- TabAndroid* tab = TabAndroid::FromWebContents(web_contents);

+ TabAndroid* tab =

+ web_contents ? TabAndroid::FromWebContents(web_contents) : nullptr;

// Regardless of whether the following call fails or not, the javascript

// call will return since startPendingPrint will make it return immediately