Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: printing/android/java/src/org/chromium/printing/PrintingContext.java

Issue 1338333002: Add checks for android printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated test. It still is kind of flaky (2/30, the print dialog comes up -> timeout), but no crash Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/android/java/src/org/chromium/printing/PrintingContext.java
diff --git a/printing/android/java/src/org/chromium/printing/PrintingContext.java b/printing/android/java/src/org/chromium/printing/PrintingContext.java
index b6c2c1164213ce19c63369f2849390858c7554c6..9520bc6f083ca7a6f992554fb16c57934a8a1f93 100644
--- a/printing/android/java/src/org/chromium/printing/PrintingContext.java
+++ b/printing/android/java/src/org/chromium/printing/PrintingContext.java
@@ -7,6 +7,7 @@
import android.print.PrintDocumentAdapter;
import android.util.SparseArray;
+import org.chromium.base.Log;
import org.chromium.base.ThreadUtils;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
@@ -18,7 +19,7 @@
*/
@JNINamespace("printing")
public class PrintingContext implements PrintingContextInterface {
-
+ private static final String TAG = "cr.printing";
/**
* Mapping from a file descriptor (as originally provided from
* {@link PrintDocumentAdapter#onWrite}) to a PrintingContext.
@@ -102,6 +103,7 @@ public void showPrintDialog() {
if (mController != null) { // The native side doesn't check if printing is enabled
mController.startPendingPrint(this);
} else {
+ Log.d(TAG, "Unable to start printing, feature not available.");
// Printing disabled. Notify the native side to stop waiting.
showSystemDialogDone();
}
@@ -116,6 +118,8 @@ public static void pdfWritingDone(int fd, boolean success) {
PrintingContext printingContext = PRINTING_CONTEXT_MAP.get(fd);
printingContext.mController.pdfWritingDone(success);
PRINTING_CONTEXT_MAP.remove(fd);
+ } else {
+ Log.d(TAG, "No PrintingContext found for fd %d, can't notify print completion.", fd);
}
}

Powered by Google App Engine
This is Rietveld 408576698