Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1333613004: Refactor WebConnectionType names (Closed)

Created:
5 years, 3 months ago by jkarlin
Modified:
5 years, 2 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@netinfo
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactor WebConnectionType names 1) https://codereview.chromium.org/1333613004 (this) 2) https://codereview.chromium.org/1310343010 3) https://codereview.chromium.org/1326543004 Committed: https://crrev.com/5c18429fe4e90c353c8204742da362f19178ac12 git-svn-id: svn://svn.chromium.org/blink/trunk@202059 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix enum and tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -59 lines) Patch
M Source/core/page/NetworkStateNotifier.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/NetworkStateNotifierTest.cpp View 1 12 chunks +41 lines, -41 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 1 chunk +8 lines, -8 lines 0 comments Download
M Source/modules/netinfo/NetworkInformation.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M public/platform/WebConnectionType.h View 1 1 chunk +12 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1308943005 Patch 240001

Dependent Patchsets:

Issue 1326543004 Patch 1

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
i guess these needs some two-sided fairy dust to land? https://codereview.chromium.org/1333613004/diff/1/Source/core/testing/Internals.cpp File Source/core/testing/Internals.cpp (right): https://codereview.chromium.org/1333613004/diff/1/Source/core/testing/Internals.cpp#newcode2403 ...
5 years, 3 months ago (2015-09-09 15:04:07 UTC) #2
jkarlin
You beat me to it. Fairy dust applied. PTAL. https://codereview.chromium.org/1333613004/diff/1/Source/core/testing/Internals.cpp File Source/core/testing/Internals.cpp (right): https://codereview.chromium.org/1333613004/diff/1/Source/core/testing/Internals.cpp#newcode2403 Source/core/testing/Internals.cpp:2403: ...
5 years, 3 months ago (2015-09-09 15:43:33 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-10 11:39:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333613004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333613004/20001
5 years, 3 months ago (2015-09-10 15:03:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202059
5 years, 3 months ago (2015-09-10 16:17:56 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:11:12 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5c18429fe4e90c353c8204742da362f19178ac12

Powered by Google App Engine
This is Rietveld 408576698