Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1326543004: Clean up WebConnectionType enum (Closed)

Created:
5 years, 3 months ago by jkarlin
Modified:
5 years, 3 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@netinfo_followup
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up WebConnectionType enum 1) https://codereview.chromium.org/1333613004 2) https://codereview.chromium.org/1310343010 3) https://codereview.chromium.org/1326543004 (this) Committed: https://crrev.com/617ba0331131e89f13524e9300dc70f2edb46f95 git-svn-id: svn://svn.chromium.org/blink/trunk@202127 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M public/platform/WebConnectionType.h View 1 chunk +1 line, -12 lines 0 comments Download

Depends on Patchset:

Issue 1333613004 Patch 20001

Messages

Total messages: 7 (2 generated)
jkarlin
jochen@ PTAL, thanks!
5 years, 3 months ago (2015-09-09 16:10:52 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-10 11:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326543004/1
5 years, 3 months ago (2015-09-11 11:03:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202127
5 years, 3 months ago (2015-09-11 11:08:09 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:21:13 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/617ba0331131e89f13524e9300dc70f2edb46f95

Powered by Google App Engine
This is Rietveld 408576698