Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1310343010: Update browser code to use new enum names for WebConnectionType (Closed)

Created:
5 years, 3 months ago by jkarlin
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update browser code to use new enum names for WebConnectionType 1) https://codereview.chromium.org/1333613004 2) https://codereview.chromium.org/1310343010 (this) 3) https://codereview.chromium.org/1326543004 Committed: https://crrev.com/3e18bda45d3c4f20f2bbd80aadc80699f7f3dc9a Cr-Commit-Position: refs/heads/master@{#348283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/renderer/net_info_helper.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jkarlin
jochen@: PTAL, thanks!
5 years, 3 months ago (2015-09-09 16:10:36 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-10 11:39:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310343010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310343010/1
5 years, 3 months ago (2015-09-10 23:01:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 23:34:23 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3e18bda45d3c4f20f2bbd80aadc80699f7f3dc9a Cr-Commit-Position: refs/heads/master@{#348283}
5 years, 3 months ago (2015-09-10 23:34:55 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:16:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e18bda45d3c4f20f2bbd80aadc80699f7f3dc9a
Cr-Commit-Position: refs/heads/master@{#348283}

Powered by Google App Engine
This is Rietveld 408576698