Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1328443003: Move configs out of targets in GN build files. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move configs out of targets in GN build files. I'm trying to disallow this since it's confusing. It looks like it provides scoping for the inner config, but it is actually no different than declaring the config at the top level. For clarify, all configs and targets should be declared at the top level. R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7858c0aae5ee449dafe23c0e1aa0c164ae2889eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -33 lines) Patch
M BUILD.gn View 2 chunks +9 lines, -8 lines 0 comments Download
M third_party/BUILD.gn View 3 chunks +30 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
brettw
5 years, 3 months ago (2015-08-31 19:43:43 UTC) #2
jam
lgtm
5 years, 3 months ago (2015-08-31 20:10:45 UTC) #3
brettw
5 years, 3 months ago (2015-08-31 20:45:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7858c0aae5ee449dafe23c0e1aa0c164ae2889eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698