Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: BUILD.gn

Issue 1328443003: Move configs out of targets in GN build files. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 4320ddf94dbe10fe5cdeff42497eab17d9759efa..ee627d157f98d734dba461c2b41a2cf6786761f3 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -393,6 +393,15 @@ static_library("fxcodec") {
]
}
+config("fxge_warnings") {
+ if (is_clang) {
+ cflags = [
+ # http://code.google.com/p/pdfium/issues/detail?id=188
+ "-Wno-switch",
+ ]
+ }
+}
+
static_library("fxcrt") {
sources = [
"core/include/fxcrt/fx_basic.h",
@@ -504,14 +513,6 @@ static_library("fxge") {
"core/src/fxge/ge/text_int.h",
]
- config("fxge_warnings") {
- if (is_clang) {
- cflags = [
- # http://code.google.com/p/pdfium/issues/detail?id=188
- "-Wno-switch",
- ]
- }
- }
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [
":pdfium_config",
« no previous file with comments | « no previous file | third_party/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698