Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: third_party/BUILD.gn

Issue 1328443003: Move configs out of targets in GN build files. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 PDFium Authors. All rights reserved. 1 # Copyright 2014 PDFium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 group("third_party") { 5 group("third_party") {
6 deps = [ 6 deps = [
7 ":bigint", 7 ":bigint",
8 ":fx_freetype", 8 ":fx_freetype",
9 ":pdfium_base", 9 ":pdfium_base",
10 ] 10 ]
(...skipping 12 matching lines...) Expand all
23 "bigint/BigIntegerUtils.cc", 23 "bigint/BigIntegerUtils.cc",
24 "bigint/BigIntegerUtils.hh", 24 "bigint/BigIntegerUtils.hh",
25 "bigint/BigUnsigned.cc", 25 "bigint/BigUnsigned.cc",
26 "bigint/BigUnsigned.hh", 26 "bigint/BigUnsigned.hh",
27 "bigint/BigUnsignedInABase.cc", 27 "bigint/BigUnsignedInABase.cc",
28 "bigint/BigUnsignedInABase.hh", 28 "bigint/BigUnsignedInABase.hh",
29 "bigint/NumberlikeArray.hh", 29 "bigint/NumberlikeArray.hh",
30 ] 30 ]
31 } 31 }
32 32
33 config("fx_freetype_warnings") {
34 visibility = [ ":*" ]
35 if (is_clang) {
36 # open_face_PS_from_sfnt_stream() and open_face_from_buffer() in
37 # ftbase.h are unused.
38 cflags = [ "-Wno-unused-function" ]
39 }
40 }
41
33 # Tests may link against this even if the production library doesn't, 42 # Tests may link against this even if the production library doesn't,
34 # so it needs to be separate from it. 43 # so it needs to be separate from it.
35 static_library("fx_freetype") { 44 static_library("fx_freetype") {
36 config("fx_freetype_warnings") {
37 if (is_clang) {
38 # open_face_PS_from_sfnt_stream() and open_face_from_buffer() in
39 # ftbase.h are unused.
40 cflags = [ "-Wno-unused-function" ]
41 }
42 }
43
44 configs -= [ "//build/config/compiler:chromium_code" ] 45 configs -= [ "//build/config/compiler:chromium_code" ]
45 configs += [ 46 configs += [
46 "//build/config/compiler:no_chromium_code", 47 "//build/config/compiler:no_chromium_code",
47 "//third_party/pdfium:pdfium_config", 48 "//third_party/pdfium:pdfium_config",
48 ":fx_freetype_warnings", 49 ":fx_freetype_warnings",
49 ] 50 ]
50 defines = [ "FT2_BUILD_LIBRARY" ] 51 defines = [ "FT2_BUILD_LIBRARY" ]
51 sources = [ 52 sources = [
52 "freetype/include/freetype.h", 53 "freetype/include/freetype.h",
53 "freetype/include/ft2build.h", 54 "freetype/include/ft2build.h",
(...skipping 20 matching lines...) Expand all
74 "freetype/src/pshinter/pshinter.c", 75 "freetype/src/pshinter/pshinter.c",
75 "freetype/src/psnames/psmodule.c", 76 "freetype/src/psnames/psmodule.c",
76 "freetype/src/raster/raster.c", 77 "freetype/src/raster/raster.c",
77 "freetype/src/sfnt/sfnt.c", 78 "freetype/src/sfnt/sfnt.c",
78 "freetype/src/smooth/smooth.c", 79 "freetype/src/smooth/smooth.c",
79 "freetype/src/truetype/truetype.c", 80 "freetype/src/truetype/truetype.c",
80 "freetype/src/type1/type1.c", 81 "freetype/src/type1/type1.c",
81 ] 82 ]
82 } 83 }
83 84
85 config("fx_agg_warnings") {
86 visibility = [ ":*" ]
87 if (is_clang) {
88 # calc_butt_cap() in agg_vcgen_stroke.cpp is unused.
89 cflags = [ "-Wno-unused-function" ]
90 }
91 }
92
84 source_set("fx_agg") { 93 source_set("fx_agg") {
85 config("fx_agg_warnings") {
86 if (is_clang) {
87 # calc_butt_cap() in agg_vcgen_stroke.cpp is unused.
88 cflags = [ "-Wno-unused-function" ]
89 }
90 }
91 configs -= [ "//build/config/compiler:chromium_code" ] 94 configs -= [ "//build/config/compiler:chromium_code" ]
92 configs += [ 95 configs += [
93 "//build/config/compiler:no_chromium_code", 96 "//build/config/compiler:no_chromium_code",
94 "//third_party/pdfium:pdfium_config", 97 "//third_party/pdfium:pdfium_config",
95 ":fx_agg_warnings", 98 ":fx_agg_warnings",
96 ] 99 ]
97 sources = [ 100 sources = [
98 "agg23/agg_basics.h", 101 "agg23/agg_basics.h",
99 "agg23/agg_clip_liang_barsky.h", 102 "agg23/agg_clip_liang_barsky.h",
100 "agg23/agg_conv_dash.h", 103 "agg23/agg_conv_dash.h",
101 "agg23/agg_conv_stroke.h", 104 "agg23/agg_conv_stroke.h",
102 "agg23/agg_curves.cpp", 105 "agg23/agg_curves.cpp",
103 "agg23/agg_curves.h", 106 "agg23/agg_curves.h",
104 "agg23/agg_path_storage.cpp", 107 "agg23/agg_path_storage.cpp",
105 "agg23/agg_path_storage.h", 108 "agg23/agg_path_storage.h",
106 "agg23/agg_rasterizer_scanline_aa.cpp", 109 "agg23/agg_rasterizer_scanline_aa.cpp",
107 "agg23/agg_rasterizer_scanline_aa.h", 110 "agg23/agg_rasterizer_scanline_aa.h",
108 "agg23/agg_renderer_scanline.h", 111 "agg23/agg_renderer_scanline.h",
109 "agg23/agg_rendering_buffer.h", 112 "agg23/agg_rendering_buffer.h",
110 "agg23/agg_scanline_u.h", 113 "agg23/agg_scanline_u.h",
111 "agg23/agg_vcgen_dash.cpp", 114 "agg23/agg_vcgen_dash.cpp",
112 "agg23/agg_vcgen_stroke.cpp", 115 "agg23/agg_vcgen_stroke.cpp",
113 ] 116 ]
114 } 117 }
115 118
119 config("fx_lcms2_warnings") {
120 visibility = [ ":*" ]
121 if (is_clang) {
122 cflags = [
123 # cmslut.cc is sloppy with aggregate initialization. Version 2.7 of this
124 # library doesn't appear to have this problem.
125 "-Wno-missing-braces",
126 # FindPrev() in cmsplugin.c is unused.
127 "-Wno-unused-function",
128 ]
129 }
130 }
131
116 source_set("fx_lcms2") { 132 source_set("fx_lcms2") {
117 config("fx_lcms2_warnings") {
118 if (is_clang) {
119 cflags = [
120 # cmslut.cc is sloppy with aggregate initialization. Version 2.7 of this
121 # library doesn't appear to have this problem.
122 "-Wno-missing-braces",
123 # FindPrev() in cmsplugin.c is unused.
124 "-Wno-unused-function",
125 ]
126 }
127 }
128 configs -= [ "//build/config/compiler:chromium_code" ] 133 configs -= [ "//build/config/compiler:chromium_code" ]
129 configs += [ 134 configs += [
130 "//build/config/compiler:no_chromium_code", 135 "//build/config/compiler:no_chromium_code",
131 "//third_party/pdfium:pdfium_config", 136 "//third_party/pdfium:pdfium_config",
132 ":fx_lcms2_warnings", 137 ":fx_lcms2_warnings",
133 ] 138 ]
134 sources = [ 139 sources = [
135 "lcms2-2.6/include/lcms2.h", 140 "lcms2-2.6/include/lcms2.h",
136 "lcms2-2.6/include/lcms2_plugin.h", 141 "lcms2-2.6/include/lcms2_plugin.h",
137 "lcms2-2.6/src/cmscam02.c", 142 "lcms2-2.6/src/cmscam02.c",
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 "base/logging.h", 296 "base/logging.h",
292 "base/macros.h", 297 "base/macros.h",
293 "base/nonstd_unique_ptr.h", 298 "base/nonstd_unique_ptr.h",
294 "base/numerics/safe_conversions.h", 299 "base/numerics/safe_conversions.h",
295 "base/numerics/safe_conversions_impl.h", 300 "base/numerics/safe_conversions_impl.h",
296 "base/numerics/safe_math.h", 301 "base/numerics/safe_math.h",
297 "base/numerics/safe_math_impl.h", 302 "base/numerics/safe_math_impl.h",
298 "base/template_util.h", 303 "base/template_util.h",
299 ] 304 ]
300 } 305 }
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698