Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: BUILD.gn

Issue 1328443003: Move configs out of targets in GN build files. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni") 5 import("//testing/test.gni")
6 6
7 pdf_use_skia = false 7 pdf_use_skia = false
8 8
9 declare_args() { 9 declare_args() {
10 # On Android there's no system FreeType. On Windows and Mac, only a few 10 # On Android there's no system FreeType. On Windows and Mac, only a few
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 # core/src/fxcodec/fx_libopenjpeg/src/fx_mct.c does an pointer-to-int 386 # core/src/fxcodec/fx_libopenjpeg/src/fx_mct.c does an pointer-to-int
387 # conversion to check that an address is 16-bit aligned (benign). 387 # conversion to check that an address is 16-bit aligned (benign).
388 cflags_c = [ "-Wno-pointer-to-int-cast" ] 388 cflags_c = [ "-Wno-pointer-to-int-cast" ]
389 } 389 }
390 configs += [ 390 configs += [
391 ":pdfium_config", 391 ":pdfium_config",
392 "//build/config/compiler:no_chromium_code", 392 "//build/config/compiler:no_chromium_code",
393 ] 393 ]
394 } 394 }
395 395
396 config("fxge_warnings") {
397 if (is_clang) {
398 cflags = [
399 # http://code.google.com/p/pdfium/issues/detail?id=188
400 "-Wno-switch",
401 ]
402 }
403 }
404
396 static_library("fxcrt") { 405 static_library("fxcrt") {
397 sources = [ 406 sources = [
398 "core/include/fxcrt/fx_basic.h", 407 "core/include/fxcrt/fx_basic.h",
399 "core/include/fxcrt/fx_bidi.h", 408 "core/include/fxcrt/fx_bidi.h",
400 "core/include/fxcrt/fx_coordinates.h", 409 "core/include/fxcrt/fx_coordinates.h",
401 "core/include/fxcrt/fx_ext.h", 410 "core/include/fxcrt/fx_ext.h",
402 "core/include/fxcrt/fx_memory.h", 411 "core/include/fxcrt/fx_memory.h",
403 "core/include/fxcrt/fx_safe_types.h", 412 "core/include/fxcrt/fx_safe_types.h",
404 "core/include/fxcrt/fx_stream.h", 413 "core/include/fxcrt/fx_stream.h",
405 "core/include/fxcrt/fx_string.h", 414 "core/include/fxcrt/fx_string.h",
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 "core/src/fxge/ge/fx_ge_device.cpp", 506 "core/src/fxge/ge/fx_ge_device.cpp",
498 "core/src/fxge/ge/fx_ge_font.cpp", 507 "core/src/fxge/ge/fx_ge_font.cpp",
499 "core/src/fxge/ge/fx_ge_fontmap.cpp", 508 "core/src/fxge/ge/fx_ge_fontmap.cpp",
500 "core/src/fxge/ge/fx_ge_linux.cpp", 509 "core/src/fxge/ge/fx_ge_linux.cpp",
501 "core/src/fxge/ge/fx_ge_path.cpp", 510 "core/src/fxge/ge/fx_ge_path.cpp",
502 "core/src/fxge/ge/fx_ge_ps.cpp", 511 "core/src/fxge/ge/fx_ge_ps.cpp",
503 "core/src/fxge/ge/fx_ge_text.cpp", 512 "core/src/fxge/ge/fx_ge_text.cpp",
504 "core/src/fxge/ge/text_int.h", 513 "core/src/fxge/ge/text_int.h",
505 ] 514 ]
506 515
507 config("fxge_warnings") {
508 if (is_clang) {
509 cflags = [
510 # http://code.google.com/p/pdfium/issues/detail?id=188
511 "-Wno-switch",
512 ]
513 }
514 }
515 configs -= [ "//build/config/compiler:chromium_code" ] 516 configs -= [ "//build/config/compiler:chromium_code" ]
516 configs += [ 517 configs += [
517 ":pdfium_config", 518 ":pdfium_config",
518 "//build/config/compiler:no_chromium_code", 519 "//build/config/compiler:no_chromium_code",
519 ":fxge_warnings", 520 ":fxge_warnings",
520 ] 521 ]
521 522
522 if (pdf_use_skia) { 523 if (pdf_use_skia) {
523 sources = [ 524 sources = [
524 "core/src/fxge/skia/fx_skia_blitter_new.cpp", 525 "core/src/fxge/skia/fx_skia_blitter_new.cpp",
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
784 "//v8", 785 "//v8",
785 "//v8/include", 786 "//v8/include",
786 "." 787 "."
787 ] 788 ]
788 configs -= [ "//build/config/compiler:chromium_code" ] 789 configs -= [ "//build/config/compiler:chromium_code" ]
789 configs += [ 790 configs += [
790 ":pdfium_config", 791 ":pdfium_config",
791 "//build/config/compiler:no_chromium_code", 792 "//build/config/compiler:no_chromium_code",
792 ] 793 ]
793 } 794 }
OLDNEW
« no previous file with comments | « no previous file | third_party/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698