Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1328263004: MD Downloads: remove malware nodes from DOM if a download isn't malware (Closed)

Created:
5 years, 3 months ago by Dan Beam
Modified:
5 years, 3 months ago
Reviewers:
tommycli
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dom-if1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: remove malware nodes from DOM if a download isn't malware R=tommycli@chromium.org BUG=526577 Committed: https://crrev.com/ffc4df78aec4cec783d52fc5a3390654e3d97dba Cr-Commit-Position: refs/heads/master@{#347879}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -31 lines) Patch
M chrome/browser/resources/md_downloads/focus_row.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 chunk +12 lines, -12 lines 2 comments Download
M chrome/browser/resources/md_downloads/item.js View 3 chunks +26 lines, -15 lines 0 comments Download

Depends on Patchset:

Issue 1325853006 Patch 100001

Dependent Patchsets:

Issue 1302293008 Patch 1

Messages

Total messages: 8 (1 generated)
Dan Beam
5 years, 3 months ago (2015-09-08 21:40:38 UTC) #1
tommycli
https://codereview.chromium.org/1328263004/diff/1/chrome/browser/resources/md_downloads/item.html File chrome/browser/resources/md_downloads/item.html (left): https://codereview.chromium.org/1328263004/diff/1/chrome/browser/resources/md_downloads/item.html#oldcode69 chrome/browser/resources/md_downloads/item.html:69: <div id="dangerous" class="controls" hidden$="[[!isDangerous_]]"> Why not dom-if the outer ...
5 years, 3 months ago (2015-09-08 22:50:08 UTC) #2
Dan Beam
https://codereview.chromium.org/1328263004/diff/1/chrome/browser/resources/md_downloads/item.html File chrome/browser/resources/md_downloads/item.html (left): https://codereview.chromium.org/1328263004/diff/1/chrome/browser/resources/md_downloads/item.html#oldcode69 chrome/browser/resources/md_downloads/item.html:69: <div id="dangerous" class="controls" hidden$="[[!isDangerous_]]"> On 2015/09/08 22:50:08, tommycli wrote: ...
5 years, 3 months ago (2015-09-08 23:08:08 UTC) #3
tommycli
lgtm then
5 years, 3 months ago (2015-09-08 23:16:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328263004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328263004/1
5 years, 3 months ago (2015-09-09 01:32:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 09:12:25 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 09:13:06 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ffc4df78aec4cec783d52fc5a3390654e3d97dba
Cr-Commit-Position: refs/heads/master@{#347879}

Powered by Google App Engine
This is Rietveld 408576698