Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1302293008: MD Downloads: use computed data binding to hide removal (X) (Closed)

Created:
5 years, 3 months ago by Dan Beam
Modified:
5 years, 3 months ago
Reviewers:
tommycli
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dom-if2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: use computed data binding to hide removal (X) R=tommycli@chromium.org BUG=526577 Committed: https://crrev.com/5368bc8ff70ad3aedd8a6de9cd37fe5aeebf6ecd Cr-Commit-Position: refs/heads/master@{#347942}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -21 lines) Patch
M chrome/browser/resources/md_downloads/item.html View 1 chunk +1 line, -0 lines 4 comments Download
M chrome/browser/resources/md_downloads/item.js View 6 chunks +18 lines, -21 lines 0 comments Download

Depends on Patchset:

Issue 1328263004 Patch 1

Dependent Patchsets:

Issue 1331573003 Patch 1
Issue 1331573003 Patch 20001

Messages

Total messages: 9 (1 generated)
Dan Beam
5 years, 3 months ago (2015-09-08 22:11:56 UTC) #1
tommycli
lgtm sans below https://codereview.chromium.org/1302293008/diff/1/chrome/browser/resources/md_downloads/item.html File chrome/browser/resources/md_downloads/item.html (right): https://codereview.chromium.org/1302293008/diff/1/chrome/browser/resources/md_downloads/item.html#newcode88 chrome/browser/resources/md_downloads/item.html:88: <div id="remove-wrapper" class="icon-wrapper"> I assume you ...
5 years, 3 months ago (2015-09-08 22:45:19 UTC) #2
Dan Beam
https://codereview.chromium.org/1302293008/diff/1/chrome/browser/resources/md_downloads/item.html File chrome/browser/resources/md_downloads/item.html (right): https://codereview.chromium.org/1302293008/diff/1/chrome/browser/resources/md_downloads/item.html#newcode88 chrome/browser/resources/md_downloads/item.html:88: <div id="remove-wrapper" class="icon-wrapper"> On 2015/09/08 22:45:19, tommycli wrote: > ...
5 years, 3 months ago (2015-09-08 23:07:35 UTC) #3
tommycli
lgtm per our in-person discussion. Not very happy with discarded params, but not unhappy enough ...
5 years, 3 months ago (2015-09-09 00:04:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302293008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302293008/1
5 years, 3 months ago (2015-09-09 16:04:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 16:10:59 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5368bc8ff70ad3aedd8a6de9cd37fe5aeebf6ecd Cr-Commit-Position: refs/heads/master@{#347942}
5 years, 3 months ago (2015-09-09 16:11:51 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:00:23 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5368bc8ff70ad3aedd8a6de9cd37fe5aeebf6ecd
Cr-Commit-Position: refs/heads/master@{#347942}

Powered by Google App Engine
This is Rietveld 408576698