Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5128)

Unified Diff: chrome/browser/resources/md_downloads/item.html

Issue 1328263004: MD Downloads: remove malware nodes from DOM if a download isn't malware (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dom-if1
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_downloads/focus_row.js ('k') | chrome/browser/resources/md_downloads/item.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_downloads/item.html
diff --git a/chrome/browser/resources/md_downloads/item.html b/chrome/browser/resources/md_downloads/item.html
index 00dd78d973f17108adb90c63f83a1747728703b2..4b0470e08a7cc656bcdea5d3b3464639e3450680 100644
--- a/chrome/browser/resources/md_downloads/item.html
+++ b/chrome/browser/resources/md_downloads/item.html
@@ -68,20 +68,20 @@
<div id="dangerous" class="controls" hidden$="[[!isDangerous_]]">
tommycli 2015/09/08 22:50:08 Why not dom-if the outer layer for !isDangerous_?
Dan Beam 2015/09/08 23:08:08 I will soon
<!-- Dangerous file types (e.g. .exe, .jar). -->
- <paper-button id="discard" i18n-content="dangerDiscard"
- on-click="onDiscardDangerous_" class="discard"
- hidden$="[[isMalware_]]"></paper-button>
- <paper-button id="save" i18n-content="dangerSave"
- on-click="onSaveDangerous_" class="keep"
- hidden$="[[isMalware_]]"></paper-button>
+ <template is="dom-if" if="[[!isMalware_]]">
+ <paper-button id="discard" on-click="onDiscardDangerous_"
+ class="discard">[[i18n_.discard]]</paper-button>
+ <paper-button id="save" on-click="onSaveDangerous_"
+ class="keep">[[i18n_.save]]</paper-button>
+ </template>
<!-- Things that safe browsing has determined to be dangerous. -->
- <paper-button id="danger-remove" i18n-content="controlRemoveFromList"
- on-click="onDiscardDangerous_" class="discard"
- hidden$="[[!isMalware_]]"></paper-button>
- <paper-button id="restore" i18n-content="dangerRestore"
- on-click="onSaveDangerous_" class="keep"
- hidden$="[[!isMalware_]]"></paper-button>
+ <template is="dom-if" if="[[isMalware_]]">
+ <paper-button id="danger-remove" on-click="onDiscardDangerous_"
+ class="discard">[[i18n_.remove]]</paper-button>
+ <paper-button id="restore" on-click="onSaveDangerous_"
+ class="keep">[[i18n_.restore]</paper-button>
+ </template>
</div>
</div>
« no previous file with comments | « chrome/browser/resources/md_downloads/focus_row.js ('k') | chrome/browser/resources/md_downloads/item.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698