MD Downloads: wrap some <paper-buttons>s in <template is="dom-if">

MD Downloads: wrap some <paper-buttons>s in <template is="dom-if">

This reduces the DOM nodes in the page roughly in half, and I haven't
even started on the dangerous ones yet :).

R=tommycli@chromium.org
BUG=526577
Committed: https://crrev.com/70837d226d3a1ed6dd45753f6dea6901466b3db6
Cr-Commit-Position: refs/heads/master@{#347851}

[Dan Beam, 2015-09-05 01:00:44]

https://codereview.chromium.org/1325853006/diff/1/chrome/browser/resources/do...
File chrome/browser/resources/downloads/downloads.html (right):

https://codereview.chromium.org/1325853006/diff/1/chrome/browser/resources/do...
chrome/browser/resources/downloads/downloads.html:69: <a is="action-link"
class="show-in-folder"
i'll do this separately

https://codereview.chromium.org/1325853006/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/item.html (right):

https://codereview.chromium.org/1325853006/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.html:43: <div id="safe"
class="controls" hidden$="[[isDangerous_]]">
this might be a dom-if

https://codereview.chromium.org/1325853006/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.html:68: <div id="dangerous"
class="controls" hidden$="[[!isDangerous_]]">
these are next up

https://codereview.chromium.org/1325853006/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/item.js (right):

https://codereview.chromium.org/1325853006/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.js:46: computed:
'computeCompletelyOnDisk_(data_.state, data_.file_externally_removed)',
can these wrap?

https://codereview.chromium.org/1325853006/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.js:185:
this.$.remove.style.visibility = hideRemove ? 'hidden' : '';
^ everything here possible will be data binding

[Dan Beam, 2015-09-05 01:01:04]

(p.s. will ping again when really ready for review, may need a little cleanup)

[Dan Beam, 2015-09-08 19:22:51]

Patchset #2 (id:20001) has been deleted

[Dan Beam, 2015-09-08 19:53:37]

Patchset #2 (id:40001) has been deleted

[Dan Beam, 2015-09-08 20:17:47]

dbeam@chromium.org changed reviewers:
+ tommycli@chromium.org

[Dan Beam, 2015-09-08 20:17:47]

+tommycli@ while michaelpg@ is busy

[Dan Beam, 2015-09-08 21:38:57]

dbeam@chromium.org changed reviewers:
- michaelpg@chromium.org

[tommycli, 2015-09-08 22:41:24]

lgtm sans below

https://codereview.chromium.org/1325853006/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/md_downloads/item.js (right):

https://codereview.chromium.org/1325853006/diff/100001/chrome/browser/resourc...
chrome/browser/resources/md_downloads/item.js:50: i18n_: {
This is unfortunate, but I was bitten by the same issue for Breadcrumb today
also, so I understand why you did this.

https://codereview.chromium.org/1325853006/diff/100001/chrome/browser/resourc...
chrome/browser/resources/md_downloads/item.js:284: isIndeterminate_: function()
{
This is called from the HTML with a parameter. Is this supposed to be a
property? Or take a parameter?

[Dan Beam, 2015-09-08 23:18:45]

https://codereview.chromium.org/1325853006/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/md_downloads/item.js (right):

https://codereview.chromium.org/1325853006/diff/100001/chrome/browser/resourc...
chrome/browser/resources/md_downloads/item.js:50: i18n_: {
On 2015/09/08 22:41:24, tommycli wrote:
> This is unfortunate, but I was bitten by the same issue for Breadcrumb today
> also, so I understand why you did this.

Acknowledged.

https://codereview.chromium.org/1325853006/diff/100001/chrome/browser/resourc...
chrome/browser/resources/md_downloads/item.js:284: isIndeterminate_: function()
{
On 2015/09/08 22:41:24, tommycli wrote:
> This is called from the HTML with a parameter. Is this supposed to be a
> property? Or take a parameter?

it could but this.data_.percent is the same as the percent arg passed, so I just
ignore the params so this could be used from another is* or compute* method,
etc.

  elevationOfThing_: function() {
    return this.isDoingSomething_() : 1 : 2;
  }

otherwise there'd be a lot of param passing

[tommycli, 2015-09-09 00:04:32]

lgtm per our in-person discussion.

Not very happy with discarded params, but not unhappy enough to block patches.

https://codereview.chromium.org/1325853006/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/md_downloads/item.js (right):

https://codereview.chromium.org/1325853006/diff/100001/chrome/browser/resourc...
chrome/browser/resources/md_downloads/item.js:284: isIndeterminate_: function()
{
On 2015/09/08 23:18:45, Dan Beam wrote:
> On 2015/09/08 22:41:24, tommycli wrote:
> > This is called from the HTML with a parameter. Is this supposed to be a
> > property? Or take a parameter?
> 
> it could but this.data_.percent is the same as the percent arg passed, so I
just
> ignore the params so this could be used from another is* or compute* method,
> etc.
> 
>   elevationOfThing_: function() {
>     return this.isDoingSomething_() : 1 : 2;
>   }
> 
> otherwise there'd be a lot of param passing

Acknowledged.

[Dan Beam, 2015-09-09 00:13:30]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-09-09 00:13:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1325853006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1325853006/100001

[commit-bot: I haz the power, 2015-09-09 00:57:29]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-09-09 00:58:09]

Patchset 4 (id:??) landed as
https://crrev.com/70837d226d3a1ed6dd45753f6dea6901466b3db6
Cr-Commit-Position: refs/heads/master@{#347851}