Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1327793002: Oilpan: Reduce FIXME(OILPAN) from the code base (Closed)

Created:
5 years, 3 months ago by haraken
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, keishi, sof
CC:
blink-reviews, eae+blinkwatch, fs, apavlov+blink_chromium.org, blink-reviews-wtf_chromium.org, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, krit, blink-reviews-css, szager+layoutwatch_chromium.org, dglazkov+blink, jchaffraix+rendering, gyuyoung2, rwlbuis, Mads Ager (chromium), zoltan1, darktears, haraken, blink-reviews-rendering, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, f(malita), oilpan-reviews, Stephen Chennney, kouhei+heap_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Reduce FIXME(OILPAN) from the code base This CL removes FIXME(OILPAN) that is out-dated or doesn't make much sense. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201639

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M Source/core/css/ElementRuleCollector.h View 1 chunk +1 line, -5 lines 1 comment Download
M Source/core/layout/svg/LayoutSVGResourceLinearGradient.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M Source/wtf/RawPtr.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
haraken
PTAL
5 years, 3 months ago (2015-09-02 09:56:43 UTC) #2
keishi
LGTM
5 years, 3 months ago (2015-09-02 10:05:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327793002/1
5 years, 3 months ago (2015-09-02 10:47:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201639
5 years, 3 months ago (2015-09-02 12:24:40 UTC) #6
sof
5 years, 3 months ago (2015-09-02 14:46:36 UTC) #8
Message was sent while issue was closed. 
please verify compilation before landing/reviewing.

https://codereview.chromium.org/1327793002/diff/1/Source/core/css/ElementRule...
File Source/core/css/ElementRuleCollector.h (right):

https://codereview.chromium.org/1327793002/diff/1/Source/core/css/ElementRule...
Source/core/css/ElementRuleCollector.h:65: RawPtrWillBeMember<const RuleData>
m_ruleData;
Needs to be additionally trace()d.

Powered by Google App Engine
This is Rietveld 408576698