Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Side by Side Diff: Source/core/svg/graphics/SVGImageChromeClient.cpp

Issue 1327793002: Oilpan: Reduce FIXME(OILPAN) from the code base (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 // As neither SVGImage nor this chrome client object are on the Oilpan heap, 95 // As neither SVGImage nor this chrome client object are on the Oilpan heap,
96 // this object's reference to the SVGImage will not be traced should a GC 96 // this object's reference to the SVGImage will not be traced should a GC
97 // strike below. Hence, we must ensure that they both remain alive for 97 // strike below. Hence, we must ensure that they both remain alive for
98 // duration of this call. 98 // duration of this call.
99 // 99 //
100 // This is cannot arise non-Oilpan as an ImageResource is an owned object 100 // This is cannot arise non-Oilpan as an ImageResource is an owned object
101 // and will be promptly released along with its (SVG)Image..and everything 101 // and will be promptly released along with its (SVG)Image..and everything
102 // below, including this object and its timer. For code simplicity, the 102 // below, including this object and its timer. For code simplicity, the
103 // object protection isn't made the conditional on Oilpan. 103 // object protection isn't made the conditional on Oilpan.
104 // 104 //
105 // FIXME: Oilpan: move this and other ChromeClients to the Oilpan heap 105 // TODO(oilpan): move SVGImage to the Oilpan heap and remove this protection .
106 // to render this protection redundant.
107 RefPtr<SVGImage> protect(m_image); 106 RefPtr<SVGImage> protect(m_image);
108 m_image->frameView()->page()->animator().serviceScriptedAnimations(monotonic allyIncreasingTime()); 107 m_image->frameView()->page()->animator().serviceScriptedAnimations(monotonic allyIncreasingTime());
109 m_image->frameView()->updateAllLifecyclePhases(); 108 m_image->frameView()->updateAllLifecyclePhases();
110 } 109 }
111 110
112 } // namespace blink 111 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698