Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: Source/core/svg/graphics/SVGImageChromeClient.cpp

Issue 1327793002: Oilpan: Reduce FIXME(OILPAN) from the code base (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/graphics/SVGImageChromeClient.cpp
diff --git a/Source/core/svg/graphics/SVGImageChromeClient.cpp b/Source/core/svg/graphics/SVGImageChromeClient.cpp
index b01faf2a0f2d126766765881fed831975ab7ac9f..6879c3711da62b3b060a3f31ac016844901cb991 100644
--- a/Source/core/svg/graphics/SVGImageChromeClient.cpp
+++ b/Source/core/svg/graphics/SVGImageChromeClient.cpp
@@ -102,8 +102,7 @@ void SVGImageChromeClient::animationTimerFired(Timer<SVGImageChromeClient>*)
// below, including this object and its timer. For code simplicity, the
// object protection isn't made the conditional on Oilpan.
//
- // FIXME: Oilpan: move this and other ChromeClients to the Oilpan heap
- // to render this protection redundant.
+ // TODO(oilpan): move SVGImage to the Oilpan heap and remove this protection.
RefPtr<SVGImage> protect(m_image);
m_image->frameView()->page()->animator().serviceScriptedAnimations(monotonicallyIncreasingTime());
m_image->frameView()->updateAllLifecyclePhases();

Powered by Google App Engine
This is Rietveld 408576698