Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: Source/platform/heap/Heap.cpp

Issue 1327793002: Oilpan: Reduce FIXME(OILPAN) from the code base (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/heap/Heap.cpp
diff --git a/Source/platform/heap/Heap.cpp b/Source/platform/heap/Heap.cpp
index 5cd8cdbed8da3cf42c369a32a89ad59964f7a4ae..df1dca7b730a8d767606bbf360af0e11e9830f88 100644
--- a/Source/platform/heap/Heap.cpp
+++ b/Source/platform/heap/Heap.cpp
@@ -574,11 +574,7 @@ void Heap::globalWeakProcessing(Visitor* visitor)
void Heap::collectAllGarbage()
{
- // FIXME: Oilpan: we should perform a single GC and everything
- // should die. Unfortunately it is not the case for all objects
- // because the hierarchy was not completely moved to the heap and
- // some heap allocated objects own objects that contain persistents
- // pointing to other heap allocated objects.
+ // We need to run multiple GCs to collect a chain of persistent handles.
size_t previousLiveObjects = 0;
for (int i = 0; i < 5; ++i) {
collectGarbage(ThreadState::NoHeapPointersOnStack, ThreadState::GCWithSweep, ForcedGC);

Powered by Google App Engine
This is Rietveld 408576698