Issue 1325173002: win x86: a few trivial compile fixes when GYP_DEFINES=target_arch=ia32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1325173002: win x86: a few trivial compile fixes when GYP_DEFINES=target_arch=ia32 (Closed)

Created:
5 years, 3 months ago by scottmg

Modified:
5 years, 3 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@crash-handler-exe-for-real

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

win x86: a few trivial compile fixes when GYP_DEFINES=target_arch=ia32 (CL to add x86 bots to waterfall in progress too.) R=mark@chromium.org BUG=crashpad:49 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/754cc3609caa4f57c147b6cd0e85fb9d94181306

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	snapshot/win/pe_image_reader_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	snapshot/win/process_reader_win_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/win/win_child_process.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Total messages: 3 (0 generated)

scottmg

5 years, 3 months ago (2015-09-03 01:35:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
754cc3609caa4f57c147b6cd0e85fb9d94181306 (presubmit successful).