snapshot/win/process_reader_win_test.cc - Issue 1325173002: win x86: a few trivial compile fixes when GYP_DEFINES=target_arch=ia32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/win/process_reader_win_test.cc

Issue 1325173002: win x86: a few trivial compile fixes when GYP_DEFINES=target_arch=ia32 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@crash-handler-exe-for-real

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/win/process_reader_win_test.cc

diff --git a/snapshot/win/process_reader_win_test.cc b/snapshot/win/process_reader_win_test.cc

index 6cd06e5bdb8c3cf3fcec79c86c6d68e62bff8af5..23306315522acd4e1dc5f45bd9e6ccf0e1640c1a 100644

--- a/snapshot/win/process_reader_win_test.cc

+++ b/snapshot/win/process_reader_win_test.cc

@@ -104,7 +104,7 @@ TEST(ProcessReaderWin, SelfOneThread) {

#if defined(ARCH_CPU_64_BITS)

EXPECT_NE(0, threads[0].context.Rip);

#else

- EXPECT_NE(0, threads[0].context.Eip);

+ EXPECT_NE(0u, threads[0].context.Eip);

#endif

EXPECT_EQ(0, threads[0].suspend_count);

« no previous file with comments | « snapshot/win/pe_image_reader_test.cc ('k') | test/win/win_child_process.cc » ('j') | no next file with comments »