snapshot/win/process_reader_win_test.cc - Issue 1325173002: win x86: a few trivial compile fixes when GYP_DEFINES=target_arch=ia32

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: snapshot/win/process_reader_win_test.cc

Issue 1325173002: win x86: a few trivial compile fixes when GYP_DEFINES=target_arch=ia32 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@crash-handler-exe-for-real

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « snapshot/win/pe_image_reader_test.cc ('k') | test/win/win_child_process.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved.	1 // Copyright 2015 The Crashpad Authors. All rights reserved.

2 //	2 //

3 // Licensed under the Apache License, Version 2.0 (the "License");	3 // Licensed under the Apache License, Version 2.0 (the "License");

4 // you may not use this file except in compliance with the License.	4 // you may not use this file except in compliance with the License.

5 // You may obtain a copy of the License at	5 // You may obtain a copy of the License at

6 //	6 //

7 // http://www.apache.org/licenses/LICENSE-2.0	7 // http://www.apache.org/licenses/LICENSE-2.0

8 //	8 //

9 // Unless required by applicable law or agreed to in writing, software	9 // Unless required by applicable law or agreed to in writing, software

10 // distributed under the License is distributed on an "AS IS" BASIS,	10 // distributed under the License is distributed on an "AS IS" BASIS,

(...skipping 86 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
97	97

98 // If other tests ran in this process previously, threads may have been	98 // If other tests ran in this process previously, threads may have been

99 // created and may still be running. This check must look for at least one	99 // created and may still be running. This check must look for at least one

100 // thread, not exactly one thread.	100 // thread, not exactly one thread.

101 ASSERT_GE(threads.size(), 1u);	101 ASSERT_GE(threads.size(), 1u);

102	102

103 EXPECT_EQ(GetThreadId(GetCurrentThread()), threads[0].id);	103 EXPECT_EQ(GetThreadId(GetCurrentThread()), threads[0].id);

104 #if defined(ARCH_CPU_64_BITS)	104 #if defined(ARCH_CPU_64_BITS)

105 EXPECT_NE(0, threads[0].context.Rip);	105 EXPECT_NE(0, threads[0].context.Rip);

106 #else	106 #else

107 EXPECT_NE(0, threads[0].context.Eip);	107 EXPECT_NE(0u, threads[0].context.Eip);

108 #endif	108 #endif

109	109

110 EXPECT_EQ(0, threads[0].suspend_count);	110 EXPECT_EQ(0, threads[0].suspend_count);

111 }	111 }

112	112

113 } // namespace	113 } // namespace

114 } // namespace test	114 } // namespace test

115 } // namespace crashpad	115 } // namespace crashpad

OLD	NEW