snapshot/win/pe_image_reader_test.cc - Issue 1325173002: win x86: a few trivial compile fixes when GYP_DEFINES=target_arch=ia32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/win/pe_image_reader_test.cc

Issue 1325173002: win x86: a few trivial compile fixes when GYP_DEFINES=target_arch=ia32 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@crash-handler-exe-for-real

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/win/pe_image_reader_test.cc

diff --git a/snapshot/win/pe_image_reader_test.cc b/snapshot/win/pe_image_reader_test.cc

index 4376f2b889f9297527db5ec582dad412084bfcab..d79415dac903a0a5abde1cc66ce7d692baeb3ae5 100644

--- a/snapshot/win/pe_image_reader_test.cc

+++ b/snapshot/win/pe_image_reader_test.cc

@@ -42,7 +42,7 @@ TEST(PEImageReader, DebugDirectory) {

DWORD age;

std::string pdbname;

EXPECT_TRUE(pe_image_reader.DebugDirectoryInformation(&uuid, &age, &pdbname));

- EXPECT_NE(-1, pdbname.find("crashpad_snapshot_test"));

+ EXPECT_NE(std::string::npos, pdbname.find("crashpad_snapshot_test"));

const std::string suffix(".pdb");

EXPECT_EQ(

« no previous file with comments | « no previous file | snapshot/win/process_reader_win_test.cc » ('j') | no next file with comments »