Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1324623005: Move sanitizer and symbol flags out of BUILDCONFIG (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, tfarina, grt+watch_chromium.org, jam, Bons, darin-cc_chromium.org, wfh+watch_chromium.org, nodir, mkwst+moarreviews-shell_chromium.org, Michael Moss, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move sanitizer and symbol flags out of BUILDCONFIG TBR=mmoss@chromium.org (chrome/installer/linux) CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/4cab0f1c83325704d637168c43fabc894f97939d Cr-Commit-Position: refs/heads/master@{#348727}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -175 lines) Patch
M base/BUILD.gn View 1 2 5 chunks +5 lines, -4 lines 0 comments Download
M base/allocator/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M base/third_party/dynamic_annotations/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M breakpad/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/config/BUILDCONFIG.gn View 1 2 3 8 chunks +13 lines, -63 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 6 chunks +146 lines, -84 lines 0 comments Download
A build/config/compiler/compiler.gni View 1 chunk +30 lines, -0 lines 0 comments Download
M build/config/sanitizers/sanitizers.gni View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M build/config/win/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M build/secondary/third_party/libjpeg_turbo/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/base/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/linux/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/win/syzygy/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M skia/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/boringssl/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/brotli/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/opus/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/docs/cookbook.md View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/geometry/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (14 generated)
brettw
Depends on https://codereview.chromium.org/1312363011 and some deps rolls.
5 years, 3 months ago (2015-09-04 20:51:23 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/1324623005/diff/1/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/1324623005/diff/1/build/config/BUILDCONFIG.gn#newcode397 build/config/BUILDCONFIG.gn:397: # Optimizations and debug checking. it seems like ...
5 years, 3 months ago (2015-09-04 22:32:26 UTC) #3
brettw
https://codereview.chromium.org/1324623005/diff/1/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/1324623005/diff/1/build/config/BUILDCONFIG.gn#newcode397 build/config/BUILDCONFIG.gn:397: # Optimizations and debug checking. On 2015/09/04 22:32:26, Dirk ...
5 years, 3 months ago (2015-09-04 23:36:24 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324623005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324623005/20001
5 years, 3 months ago (2015-09-10 03:19:42 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/79897) linux_chromium_rel_ng on ...
5 years, 3 months ago (2015-09-10 03:22:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324623005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324623005/20001
5 years, 3 months ago (2015-09-10 17:01:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/130860) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-10 17:07:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324623005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324623005/40001
5 years, 3 months ago (2015-09-14 18:08:27 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/40347)
5 years, 3 months ago (2015-09-14 18:21:09 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324623005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324623005/60001
5 years, 3 months ago (2015-09-14 19:34:27 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/99503)
5 years, 3 months ago (2015-09-14 20:05:10 UTC) #23
brettw
TBR mmoss for chrome/installer/linux
5 years, 3 months ago (2015-09-14 20:34:11 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324623005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324623005/60001
5 years, 3 months ago (2015-09-14 20:36:12 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-14 21:40:12 UTC) #28
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/4cab0f1c83325704d637168c43fabc894f97939d Cr-Commit-Position: refs/heads/master@{#348727}
5 years, 3 months ago (2015-09-14 21:41:24 UTC) #29
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:37:35 UTC) #30
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/4cab0f1c83325704d637168c43fabc894f97939d
Cr-Commit-Position: refs/heads/master@{#348727}

Powered by Google App Engine
This is Rietveld 408576698