Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1312363011: Add a flag to BUILDCONFIG for updating some global configs. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a flag to BUILDCONFIG for updating some global configs. This is part one of a multi-way landing, as described in the comment for the added flag. The patch that this enables is https://codereview.chromium.org/1324623005/ which will be landed after ffmpeg and WebKit have been updated. Committed: https://crrev.com/96453de346274c747c13d89c2ffaf9a6ce0ba667 Cr-Commit-Position: refs/heads/master@{#347495}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
5 years, 3 months ago (2015-09-04 20:48:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312363011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312363011/20001
5 years, 3 months ago (2015-09-04 21:18:50 UTC) #4
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-04 21:24:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312363011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312363011/20001
5 years, 3 months ago (2015-09-04 21:25:32 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-04 21:53:06 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 21:53:47 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/96453de346274c747c13d89c2ffaf9a6ce0ba667
Cr-Commit-Position: refs/heads/master@{#347495}

Powered by Google App Engine
This is Rietveld 408576698