Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1323053003: Add ijar to third_party and use it for generating .jar.toc files in GN (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@compiled_action
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ijar to third_party and use it for generating .jar.toc files in GN It's much faster than using javap (what we currently do): With javap, building chrome_java: real 1m17.162s user 7m46.230s sys 0m42.836s With ijar, building chrome_java: real 0m56.446s user 5m38.761s sys 0m26.006s BUG=527632 Committed: https://crrev.com/77614d453e6324c9da3e12b93b4c19800cbe09a9 Cr-Commit-Position: refs/heads/master@{#347208}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix release mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3504 lines, -21 lines) Patch
M build/config/android/internal_rules.gni View 1 2 chunks +6 lines, -20 lines 0 comments Download
A third_party/ijar/BUILD View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/ijar/BUILD.gn View 1 1 chunk +27 lines, -0 lines 0 comments Download
A + third_party/ijar/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/ijar/OWNERS View 1 chunk +1 line, -2 lines 0 comments Download
A third_party/ijar/README.chromium View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/ijar/README.txt View 1 chunk +120 lines, -0 lines 0 comments Download
A third_party/ijar/classfile.cc View 1 chunk +1489 lines, -0 lines 0 comments Download
A third_party/ijar/common.h View 1 chunk +102 lines, -0 lines 0 comments Download
A third_party/ijar/ijar.cc View 1 chunk +182 lines, -0 lines 0 comments Download
A third_party/ijar/ijar.gni View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/ijar/zip.h View 1 chunk +169 lines, -0 lines 0 comments Download
A third_party/ijar/zip.cc View 1 chunk +1014 lines, -0 lines 0 comments Download
A third_party/ijar/zip_main.cc View 1 chunk +312 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
agrieve
klobag: for third_party rubber stamp dpranke: for GN rules
5 years, 3 months ago (2015-09-03 02:45:27 UTC) #2
klobag.chromium
lgtm
5 years, 3 months ago (2015-09-03 14:52:48 UTC) #3
Dirk Pranke
lgtm https://codereview.chromium.org/1323053003/diff/1/third_party/ijar/BUILD.gn File third_party/ijar/BUILD.gn (right): https://codereview.chromium.org/1323053003/diff/1/third_party/ijar/BUILD.gn#newcode18 third_party/ijar/BUILD.gn:18: "//build/config:debug", Does this fail in a release build?
5 years, 3 months ago (2015-09-03 15:48:15 UTC) #4
Daniel Berlin
LGTM to OSTPR
5 years, 3 months ago (2015-09-03 15:55:19 UTC) #6
agrieve
https://codereview.chromium.org/1323053003/diff/1/third_party/ijar/BUILD.gn File third_party/ijar/BUILD.gn (right): https://codereview.chromium.org/1323053003/diff/1/third_party/ijar/BUILD.gn#newcode18 third_party/ijar/BUILD.gn:18: "//build/config:debug", On 2015/09/03 15:48:15, Dirk Pranke wrote: > Does ...
5 years, 3 months ago (2015-09-03 18:38:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323053003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323053003/20001
5 years, 3 months ago (2015-09-03 18:39:29 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-03 19:12:25 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 19:13:10 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77614d453e6324c9da3e12b93b4c19800cbe09a9
Cr-Commit-Position: refs/heads/master@{#347208}

Powered by Google App Engine
This is Rietveld 408576698