GN: Stop setting android.jar in both -classpath and -bootclasspath

GN: Stop setting android.jar in both -classpath and -bootclasspath

I don't think it's necessary.

BUG=

Committed: https://crrev.com/6c26dd145dffde7cc1a5d0025ed2b5fd35cc6bae
Cr-Commit-Position: refs/heads/master@{#347330}

[agrieve, 2015-09-03 18:39:45]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-03 18:40:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1328793003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1328793003/20001

[agrieve, 2015-09-03 18:51:12]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-03 18:51:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1328793003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1328793003/40001

[commit-bot: I haz the power, 2015-09-03 19:40:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 19:40:07]

Dry run: This issue passed the CQ dry run.

[agrieve, 2015-09-03 19:54:52]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-09-03 20:11:30]

https://codereview.chromium.org/1328793003/diff/40001/build/config/android/in...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1328793003/diff/40001/build/config/android/in...
build/config/android/internal_rules.gni:1163: assert(_requires_android || true) 
# Mark as used.
if this isn't actually used, why not delete it?

[agrieve, 2015-09-04 00:05:38]

https://codereview.chromium.org/1328793003/diff/40001/build/config/android/in...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1328793003/diff/40001/build/config/android/in...
build/config/android/internal_rules.gni:1163: assert(_requires_android || true) 
# Mark as used.
On 2015/09/03 20:11:30, Dirk Pranke wrote:
> if this isn't actually used, why not delete it?

It's still used in the write_build_config step. GN just complains if it's not
used on both sides of the condition. I could move it into the condition, but I
think it's nice to have this right beside  _supports_android.

[Dirk Pranke, 2015-09-04 00:54:09]

https://codereview.chromium.org/1328793003/diff/40001/build/config/android/in...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1328793003/diff/40001/build/config/android/in...
build/config/android/internal_rules.gni:1163: assert(_requires_android || true) 
# Mark as used.
On 2015/09/04 00:05:38, agrieve wrote:
> On 2015/09/03 20:11:30, Dirk Pranke wrote:
> > if this isn't actually used, why not delete it?
> 
> It's still used in the write_build_config step. GN just complains if it's not
> used on both sides of the condition. I could move it into the condition, but I
> think it's nice to have this right beside  _supports_android.

Hm. That kinda sounds like a bug in GN. Maybe file a bug and follow up w/ Brett?

lgtm in the meantime.

[agrieve, 2015-09-04 01:28:04]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-09-04 01:28:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1328793003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1328793003/40001

[agrieve, 2015-09-04 01:35:15]

On 2015/09/04 00:54:09, Dirk Pranke wrote:
>
https://codereview.chromium.org/1328793003/diff/40001/build/config/android/in...
> File build/config/android/internal_rules.gni (right):
> 
>
https://codereview.chromium.org/1328793003/diff/40001/build/config/android/in...
> build/config/android/internal_rules.gni:1163: assert(_requires_android ||
true) 
> # Mark as used.
> On 2015/09/04 00:05:38, agrieve wrote:
> > On 2015/09/03 20:11:30, Dirk Pranke wrote:
> > > if this isn't actually used, why not delete it?
> > 
> > It's still used in the write_build_config step. GN just complains if it's
not
> > used on both sides of the condition. I could move it into the condition, but
I
> > think it's nice to have this right beside  _supports_android.
> 
> Hm. That kinda sounds like a bug in GN. Maybe file a bug and follow up w/
Brett?
> 
> lgtm in the meantime.

I think it's this one:
https://code.google.com/p/chromium/issues/detail?id=395883

[commit-bot: I haz the power, 2015-09-04 03:08:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-04 03:09:18]

Patchset 3 (id:??) landed as
https://crrev.com/6c26dd145dffde7cc1a5d0025ed2b5fd35cc6bae
Cr-Commit-Position: refs/heads/master@{#347330}

[Dirk Pranke, 2015-09-04 15:47:07]

On 2015/09/04 01:35:15, agrieve wrote:
> On 2015/09/04 00:54:09, Dirk Pranke wrote:
> > Hm. That kinda sounds like a bug in GN. Maybe file a bug and follow up w/
> Brett?
> > 
> > lgtm in the meantime.
> 
> I think it's this one:
> https://code.google.com/p/chromium/issues/detail?id=395883

Oh, right. I had forgotten about that one.