Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1321763002: [VR, Permission] Use appopriate type parameters for WebCallbacks (3/3) (Closed)

Created:
5 years, 3 months ago by yhirano
Modified:
5 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, mlamouri+watch-blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[VR, Permission] Use appopriate type parameters for WebCallbacks (3/3) - WebPermissionStatus* (ownership transferred) => WebPermissionStatus - WebVector<WebVRDevice>* (ownership not transferred) => const WebVector<WebVRDevice>& 1/3: https://codereview.chromium.org/1317243002/ 2/3: https://codereview.chromium.org/1309803006/ 3/3: https://codereview.chromium.org/1321763002/ BUG=493531 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M public/platform/modules/permissions/WebPermissionClient.h View 1 chunk +1 line, -9 lines 0 comments Download
M public/platform/modules/vr/WebVRClient.h View 1 chunk +1 line, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
yhirano
5 years, 3 months ago (2015-08-28 09:35:23 UTC) #2
mlamouri (slow - plz ping)
lgtm
5 years, 3 months ago (2015-08-28 10:45:52 UTC) #3
bajones
modules/vr LGTM.
5 years, 3 months ago (2015-08-28 16:44:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321763002/1
5 years, 3 months ago (2015-09-02 03:09:22 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 03:57:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201610

Powered by Google App Engine
This is Rietveld 408576698