Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1317243002: [VR, Permission] Use appopriate type parameters for WebCallbacks (1/3) (Closed)

Created:
5 years, 3 months ago by yhirano
Modified:
5 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, kinuko+fileapi, mlamouri+watch-blink_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[VR, Permission] Use appopriate type parameters for WebCallbacks (1/3) - WebPermissionStatus* (ownership transferred) => WebPermissionStatus - WebVector<WebVRDevice>* (ownership not transferred) => const WebVector<WebVRDevice>& 1/3: https://codereview.chromium.org/1317243002/ 2/3: https://codereview.chromium.org/1309803006/ 3/3: https://codereview.chromium.org/1321763002/ BUG=493531 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -38 lines) Patch
M Source/modules/permissions/PermissionCallback.h View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/permissions/PermissionCallback.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/permissions/PermissionStatus.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/permissions/PermissionStatus.cpp View 1 chunk +2 lines, -10 lines 0 comments Download
M Source/modules/quota/StorageManager.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M Source/modules/vr/VRGetDevicesCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRGetDevicesCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRHardwareUnitCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRHardwareUnitCollection.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M public/platform/modules/permissions/WebPermissionClient.h View 1 chunk +9 lines, -1 line 0 comments Download
M public/platform/modules/vr/WebVRClient.h View 1 chunk +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
yhirano
5 years, 3 months ago (2015-08-28 09:33:00 UTC) #2
yhirano
+bajones@
5 years, 3 months ago (2015-08-28 09:35:47 UTC) #4
nhiroki
LGTM for modules/quota/
5 years, 3 months ago (2015-08-28 09:41:30 UTC) #5
mlamouri (slow - plz ping)
lgtm. Thanks for doing that! :)
5 years, 3 months ago (2015-08-28 10:44:24 UTC) #6
bajones
modules/vr LGTM, thanks!
5 years, 3 months ago (2015-08-28 16:42:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317243002/1
5 years, 3 months ago (2015-09-01 05:23:11 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 08:45:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201537

Powered by Google App Engine
This is Rietveld 408576698