Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1309803006: [VR, Permission] Use appopriate type parameters for WebCallbacks (2/3) (Closed)

Created:
5 years, 3 months ago by yhirano
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[VR, Permission] Use appopriate type parameters for WebCallbacks (2/3) - WebPermissionStatus* (ownership transferred) => WebPermissionStatus - WebVector<WebVRDevice>* (ownership not transferred) => const WebVector<WebVRDevice>& 1/3: https://codereview.chromium.org/1317243002/ 2/3: https://codereview.chromium.org/1309803006/ 3/3: https://codereview.chromium.org/1321763002/ BUG=493531 Committed: https://crrev.com/391a9d48db67e99c98f3de18e78fe2a08946b7c1 Cr-Commit-Position: refs/heads/master@{#346619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M content/child/permissions/permission_dispatcher.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/child/permissions/permission_dispatcher.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M content/renderer/vr/vr_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
yhirano
5 years, 3 months ago (2015-08-28 09:34:40 UTC) #2
mlamouri (slow - plz ping)
lgtm
5 years, 3 months ago (2015-08-28 10:45:44 UTC) #3
bajones
On 2015/08/28 10:45:44, Mounir Lamouri wrote: > lgtm renderer/vr LGTM, though it looks like I'm ...
5 years, 3 months ago (2015-08-28 16:43:36 UTC) #4
yhirano
+kinuko for OWNER review.
5 years, 3 months ago (2015-08-31 06:01:44 UTC) #6
kinuko
lgtm!
5 years, 3 months ago (2015-08-31 06:04:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309803006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309803006/1
5 years, 3 months ago (2015-09-01 09:18:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 10:55:29 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 10:56:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/391a9d48db67e99c98f3de18e78fe2a08946b7c1
Cr-Commit-Position: refs/heads/master@{#346619}

Powered by Google App Engine
This is Rietveld 408576698