Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1321353002: Limit lifetime of GrDrawContext objects (Closed)

Created:
5 years, 3 months ago by robertphillips
Modified:
5 years, 3 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Limit lifetime of GrDrawContext objects GrDrawContext's are about to become real allocated objects. This CL sets up the machinery so they won't leak. Committed: https://skia.googlesource.com/skia/+/c9a3706f1ee38c331610ec1e872d9a658566c397

Patch Set 1 #

Patch Set 2 : update to ToT #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -37 lines) Patch
M gm/texdata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 10 chunks +13 lines, -13 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 chunk +5 lines, -1 line 2 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/SkGr.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
robertphillips
5 years, 3 months ago (2015-09-01 13:24:01 UTC) #2
jvanverth1
lgtm + comment https://codereview.chromium.org/1321353002/diff/20001/src/gpu/GrRenderTarget.cpp File src/gpu/GrRenderTarget.cpp (right): https://codereview.chromium.org/1321353002/diff/20001/src/gpu/GrRenderTarget.cpp#newcode26 src/gpu/GrRenderTarget.cpp:26: if (!drawContext) { Is this check ...
5 years, 3 months ago (2015-09-01 14:43:37 UTC) #3
robertphillips
https://codereview.chromium.org/1321353002/diff/20001/src/gpu/GrRenderTarget.cpp File src/gpu/GrRenderTarget.cpp (right): https://codereview.chromium.org/1321353002/diff/20001/src/gpu/GrRenderTarget.cpp#newcode26 src/gpu/GrRenderTarget.cpp:26: if (!drawContext) { On 2015/09/01 14:43:37, jvanverth1 wrote: > ...
5 years, 3 months ago (2015-09-01 14:49:05 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321353002/20001
5 years, 3 months ago (2015-09-01 14:49:19 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-01 14:56:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321353002/20001
5 years, 3 months ago (2015-09-01 15:33:43 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 15:34:31 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c9a3706f1ee38c331610ec1e872d9a658566c397

Powered by Google App Engine
This is Rietveld 408576698