src/core/SkImageFilter.cpp - Issue 1321353002: Limit lifetime of GrDrawContext objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkImageFilter.cpp

Issue 1321353002: Limit lifetime of GrDrawContext objects (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: update to ToT Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkImageFilter.cpp

diff --git a/src/core/SkImageFilter.cpp b/src/core/SkImageFilter.cpp

index cda3e053b9fea7282bded7da67c42431184bcc2e..32562946ed54c2baa82fbd8c2a4e39f35ac814ce 100644

--- a/src/core/SkImageFilter.cpp

+++ b/src/core/SkImageFilter.cpp

@@ -354,7 +354,7 @@ bool SkImageFilter::filterImageGPU(Proxy* proxy, const SkBitmap& src, const Cont

SkASSERT(fp);

paint.addColorFragmentProcessor(fp)->unref();

- GrDrawContext* drawContext = context->drawContext();

+ SkAutoTUnref<GrDrawContext> drawContext(context->drawContext());

if (drawContext) {

drawContext->drawNonAARectToRect(dst->asRenderTarget(), clip, paint, SkMatrix::I(),

dstRect, srcRect);