Introduce {left,right}PositionOf() for VisiblePosition

Introduce {left,right}PositionOf() for VisiblePosition

This patch introduces |{left,right}PositionOf()| function for |VisiblePosition|
as replacement of |VisiblePosition::{left,right}()| to simplify
|VisiblePosition| class for ease of templataizing |VisiblePosition| class to
introduce composed tree version of |VisiblePosition|, since an implementation of
|VisiblePosition::{left,right}()| can be implemented with public member
functions of |VisiblePosition| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201402

[yosin_UTC9, 2015-08-28 08:27:25]

yosin@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2015-08-28 08:27:25]

PTAL

[hajimehoshi, 2015-08-28 08:33:57]

lgtm

Just out of curiosity, do you plan to remove VisibulePosition or replace this
with something?

[yosin_UTC9, 2015-08-28 08:34:39]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-08-28 08:34:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321033002/1

[commit-bot: I haz the power, 2015-08-28 09:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-28 09:47:52]

Failed to apply patch for Source/core/editing/VisiblePosition.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/editing/VisiblePosition.h
  Hunk #1 succeeded at 101 with fuzz 2 (offset -1 lines).
  Hunk #2 FAILED at 128.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/editing/VisiblePosition.h.rej

Patch:       Source/core/editing/VisiblePosition.h
Index: Source/core/editing/VisiblePosition.h
diff --git a/Source/core/editing/VisiblePosition.h
b/Source/core/editing/VisiblePosition.h
index
405202bf5a05e75eed0d389c8184713dc6f8fe14..2a64fcd691448bb8ae5369de872c170d980fb439
100644
--- a/Source/core/editing/VisiblePosition.h
+++ b/Source/core/editing/VisiblePosition.h
@@ -102,9 +102,6 @@ public:
     VisiblePosition skipToStartOfEditingBoundary(const VisiblePosition&) const;
     VisiblePosition skipToEndOfEditingBoundary(const VisiblePosition&) const;
 
-    VisiblePosition left() const;
-    VisiblePosition right() const;
-
     UChar32 characterAfter() const;
     UChar32 characterBefore() const { return previous().characterAfter(); }
 
@@ -131,15 +128,17 @@ private:
     template<typename Strategy>
     void init(const PositionAlgorithm<Strategy>&, TextAffinity);
 
-    Position leftVisuallyDistinctCandidate() const;
-    Position rightVisuallyDistinctCandidate() const;
-
     Position m_deepPosition;
     TextAffinity m_affinity;
 };
 
 EphemeralRange makeRange(const VisiblePosition&, const VisiblePosition&);
 
+// TODO(yosin) We should move |leftPositionOf()| and |rightPositionOf()| to
+// "VisibleUnits.cpp".
+VisiblePosition leftPositionOf(const VisiblePosition&);
+VisiblePosition rightPositionOf(const VisiblePosition&);
+
 CORE_EXPORT Position canonicalPositionOf(const Position&);
 CORE_EXPORT PositionInComposedTree canonicalPositionOf(const
PositionInComposedTree&);
 PositionWithAffinity honorEditingBoundaryAtOrBeforeOf(const
PositionWithAffinity&, const Position& anchor);

[commit-bot: I haz the power, 2015-08-28 09:47:54]

The CQ bit was unchecked by commit-bot@chromium.org

[yosin_UTC9, 2015-08-28 10:07:46]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2015-08-28 10:07:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
hajimehoshi@chromium.org
Link to the patchset: https://codereview.chromium.org/1321033002/#ps20001
(title: "2015-08-28T19:07:16 Rebase")

[commit-bot: I haz the power, 2015-08-28 10:07:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321033002/20001

[commit-bot: I haz the power, 2015-08-28 11:21:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-28 11:21:40]

Failed to apply patch for Source/core/editing/VisiblePosition.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/editing/VisiblePosition.h
  Hunk #1 FAILED at 101.
  Hunk #2 succeeded at 123 (offset -4 lines).
  Hunk #3 succeeded at 136 with fuzz 1 (offset -4 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
Source/core/editing/VisiblePosition.h.rej

Patch:       Source/core/editing/VisiblePosition.h
Index: Source/core/editing/VisiblePosition.h
diff --git a/Source/core/editing/VisiblePosition.h
b/Source/core/editing/VisiblePosition.h
index
d0a4d776bfdb4c053d2d75cee562797e70c3d422..4f8e630c5ea6ab5693d394c0410be80440ed699f
100644
--- a/Source/core/editing/VisiblePosition.h
+++ b/Source/core/editing/VisiblePosition.h
@@ -101,9 +101,6 @@ public:
     VisiblePosition skipToStartOfEditingBoundary(const VisiblePosition&) const;
     VisiblePosition skipToEndOfEditingBoundary(const VisiblePosition&) const;
 
-    VisiblePosition left() const;
-    VisiblePosition right() const;
-
     UChar32 characterAfter() const;
     UChar32 characterBefore() const;
 
@@ -127,9 +124,6 @@ private:
     template<typename Strategy>
     void init(const PositionAlgorithm<Strategy>&, TextAffinity);
 
-    Position leftVisuallyDistinctCandidate() const;
-    Position rightVisuallyDistinctCandidate() const;
-
     Position m_deepPosition;
     TextAffinity m_affinity;
 };
@@ -143,6 +137,11 @@ int lineDirectionPointForBlockDirectionNavigationOf(const
VisiblePosition&);
 
 EphemeralRange makeRange(const VisiblePosition&, const VisiblePosition&);
 
+// TODO(yosin) We should move |leftPositionOf()| and |rightPositionOf()| to
+// "VisibleUnits.cpp".
+VisiblePosition leftPositionOf(const VisiblePosition&);
+VisiblePosition rightPositionOf(const VisiblePosition&);
+
 CORE_EXPORT Position canonicalPositionOf(const Position&);
 CORE_EXPORT PositionInComposedTree canonicalPositionOf(const
PositionInComposedTree&);
 PositionWithAffinity honorEditingBoundaryAtOrBeforeOf(const
PositionWithAffinity&, const Position& anchor);

[commit-bot: I haz the power, 2015-08-28 11:21:44]

The CQ bit was unchecked by commit-bot@chromium.org

[yosin_UTC9, 2015-08-28 13:00:35]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2015-08-28 13:00:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
hajimehoshi@chromium.org
Link to the patchset: https://codereview.chromium.org/1321033002/#ps40001
(title: "2015-08-28T21:59:15 Rebase after merge failure")

[commit-bot: I haz the power, 2015-08-28 13:00:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321033002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321033002/40001

[commit-bot: I haz the power, 2015-08-28 14:08:05]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201402