Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: Source/core/editing/VisiblePosition.h

Issue 1321033002: Introduce {left,right}PositionOf() for VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-28T21:59:15 Rebase after merge failure Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisiblePosition.h
diff --git a/Source/core/editing/VisiblePosition.h b/Source/core/editing/VisiblePosition.h
index 2e107c06838de136b4adaeaa04d6c9535e86f552..6cca7d9fc072c1e06f7a64e9c6ad7057fbd4d9a8 100644
--- a/Source/core/editing/VisiblePosition.h
+++ b/Source/core/editing/VisiblePosition.h
@@ -100,10 +100,7 @@ public:
VisiblePosition skipToStartOfEditingBoundary(const VisiblePosition&) const;
VisiblePosition skipToEndOfEditingBoundary(const VisiblePosition&) const;
- VisiblePosition left() const;
- VisiblePosition right() const;
-
- // FIXME: This does not handle [table, 0] correctly.
+ // TODO(yosin) This does not handle [table, 0] correctly.
Element* rootEditableElement() const { return m_deepPosition.isNotNull() ? m_deepPosition.anchorNode()->rootEditableElement() : 0; }
// Rect is local to the returned layoutObject
@@ -123,9 +120,6 @@ private:
template<typename Strategy>
void init(const PositionAlgorithm<Strategy>&, TextAffinity);
- Position leftVisuallyDistinctCandidate() const;
- Position rightVisuallyDistinctCandidate() const;
-
Position m_deepPosition;
TextAffinity m_affinity;
};
@@ -139,6 +133,11 @@ int lineDirectionPointForBlockDirectionNavigationOf(const VisiblePosition&);
EphemeralRange makeRange(const VisiblePosition&, const VisiblePosition&);
+// TODO(yosin) We should move |leftPositionOf()| and |rightPositionOf()| to
+// "VisibleUnits.cpp".
+VisiblePosition leftPositionOf(const VisiblePosition&);
+VisiblePosition rightPositionOf(const VisiblePosition&);
+
CORE_EXPORT Position canonicalPositionOf(const Position&);
CORE_EXPORT PositionInComposedTree canonicalPositionOf(const PositionInComposedTree&);
// TODO(yosin) We should move |characterAfter()| and |characterBefore()| to
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698