Introduce {left,right}PositionOf() for VisiblePosition

Source/core/editing/VisiblePosition.h

 /*
  * Copyright (C) 2004, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 82 matching lines @@
     Position toParentAnchoredPosition() const { return deepEquivalent().parentAnchoredEquivalent(); }
     PositionWithAffinity toPositionWithAffinity() const { return PositionWithAffinity(m_deepPosition, m_affinity); }
     TextAffinity affinity() const { return m_affinity; }
 
     // next() and previous() will increment/decrement by a character cluster.
     VisiblePosition honorEditingBoundaryAtOrBefore(const VisiblePosition&) const;
     VisiblePosition honorEditingBoundaryAtOrAfter(const VisiblePosition&) const;
     VisiblePosition skipToStartOfEditingBoundary(const VisiblePosition&) const;
     VisiblePosition skipToEndOfEditingBoundary(const VisiblePosition&) const;
 
-    VisiblePosition left() const;
-    VisiblePosition right() const;
-
-    // FIXME: This does not handle [table, 0] correctly.
+    // TODO(yosin) This does not handle [table, 0] correctly.
     Element* rootEditableElement() const { return m_deepPosition.isNotNull() ? m_deepPosition.anchorNode()->rootEditableElement() : 0; }
 
     // Rect is local to the returned layoutObject
     LayoutRect localCaretRect(LayoutObject*&) const;
     // Bounds of (possibly transformed) caret in absolute coords
     IntRect absoluteCaretBounds() const;
 
     DECLARE_TRACE();
 
 #ifndef NDEBUG
     void debugPosition(const char* msg = "") const;
     void formatForDebugger(char* buffer, unsigned length) const;
     void showTreeForThis() const;
 #endif
 
 private:
     template<typename Strategy>
     void init(const PositionAlgorithm<Strategy>&, TextAffinity);
 
-    Position leftVisuallyDistinctCandidate() const;
-    Position rightVisuallyDistinctCandidate() const;
-
     Position m_deepPosition;
     TextAffinity m_affinity;
 };
 
 // Abs x/y position of the caret ignoring transforms.
 // TODO(yosin) navigation with transforms should be smarter.
 // TODO(yosin) We should move a glboal funciton
 // |lineDirectionPointForBlockDirectionNavigationOf()| to "FrameSelection.h"
 // as static function.
 int lineDirectionPointForBlockDirectionNavigationOf(const VisiblePosition&);
 
 EphemeralRange makeRange(const VisiblePosition&, const VisiblePosition&);
 
+// TODO(yosin) We should move |leftPositionOf()| and |rightPositionOf()| to
+// "VisibleUnits.cpp".
+VisiblePosition leftPositionOf(const VisiblePosition&);
+VisiblePosition rightPositionOf(const VisiblePosition&);
+
 CORE_EXPORT Position canonicalPositionOf(const Position&);
 CORE_EXPORT PositionInComposedTree canonicalPositionOf(const PositionInComposedTree&);
 // TODO(yosin) We should move |characterAfter()| and |characterBefore()| to
 // "VisibleUnits.cpp"
 UChar32 characterAfter(const VisiblePosition&);
 UChar32 characterBefore(const VisiblePosition&);
 PositionWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionWithAffinity&, const Position& anchor);
 PositionInComposedTreeWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionInComposedTreeWithAffinity&, const PositionInComposedTree& anchor);
 
 // TODO(yosin) We should move |nextPositionOf()| to "VisibleUnits.cpp".
 VisiblePosition nextPositionOf(const VisiblePosition&, EditingBoundaryCrossingRule = CanCrossEditingBoundary);
 // TODO(yosin) We should move |previousPositionOf()| to "VisibleUnits.cpp"
 VisiblePosition previousPositionOf(const VisiblePosition&, EditingBoundaryCrossingRule = CanCrossEditingBoundary);
 
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showTree(const blink::VisiblePosition*);
 void showTree(const blink::VisiblePosition&);
 #endif
 
 #endif // VisiblePosition_h