Source/core/editing/FrameSelection.cpp - Issue 1321033002: Introduce {left,right}PositionOf() for VisiblePosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 1321033002: Introduce {left,right}PositionOf() for VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-28T21:59:15 Rebase after merge failure Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/FrameSelection.cpp

diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp

index 8e1bb5b034fb5f247eaa5d56ff3d9deb07bac6ee..b22bccc865a974ddbfd59dc1a4eb20f306f41d8e 100644

--- a/Source/core/editing/FrameSelection.cpp

+++ b/Source/core/editing/FrameSelection.cpp

@@ -747,7 +747,7 @@ VisiblePosition FrameSelection::modifyMovingRight(TextGranularity granularity)

else

pos = VisiblePosition(m_selection.start(), m_selection.affinity());

} else {

- pos = VisiblePosition(m_selection.extent(), m_selection.affinity()).right();

+ pos = rightPositionOf(VisiblePosition(m_selection.extent(), m_selection.affinity()));

}

break;

case WordGranularity: {

@@ -916,7 +916,7 @@ VisiblePosition FrameSelection::modifyMovingLeft(TextGranularity granularity)

else

pos = VisiblePosition(m_selection.end(), m_selection.affinity());

} else {

- pos = VisiblePosition(m_selection.extent(), m_selection.affinity()).left();

+ pos = leftPositionOf(VisiblePosition(m_selection.extent(), m_selection.affinity()));

}

break;

case WordGranularity: {

« no previous file with comments | « no previous file | Source/core/editing/VisiblePosition.h » ('j') | no next file with comments »