Issue 132081: Comments added to SSL unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132081: Comments added to SSL unit tests. (Closed)

Created:
11 years, 6 months ago by John Grabowski

Modified:
9 years, 5 months ago

Reviewers:
TVL, wtc

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Comments added to SSL unit tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18835

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -0 lines)			Patch
	M	net/base/ssl_client_socket_unittest.cc	View	1	1 chunk	+12 lines, -0 lines	1 comment	Download
	M	net/url_request/url_request_unittest.cc	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

Results (generous term) from my day on the non-feature fixit.

11 years, 6 months ago (2009-06-19 17:56:57 UTC) #1

TVL

lgtm is it worth looping in wtc or someone to help look at these? not ...

11 years, 6 months ago (2009-06-19 18:00:32 UTC) #2

wtc

11 years, 6 months ago (2009-06-19 18:15:25 UTC) #3

LGTM.  I can look into these test issues in July.

http://codereview.chromium.org/132081/diff/1003/1005
File net/base/ssl_client_socket_unittest.cc (right):

http://codereview.chromium.org/132081/diff/1003/1005#newcode64
Line 64: // http://dev.chromium.org/developers/testing, the -9812 becomes a
This seems to imply that after importing the test root CA
into the keychain, we need to do something else to trust it.

Expand Messages | Collapse Messages