Comments added to SSL unit tests.

net/base/ssl_client_socket_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/address_list.h"
 #include "net/base/client_socket_factory.h"
 #include "net/base/host_resolver.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
 #include "net/base/ssl_client_socket.h"
@@ skipping 36 matching lines @@
   }
 
  protected:
   net::ClientSocketFactory* socket_factory_;
   net::TestServerLauncher server_;
 };
 
 //-----------------------------------------------------------------------------
 
 #if defined(OS_MACOSX)
+// Status 6/19/09:
+//
+// If these tests are enabled on OSX, we choke at the point
+// SSLHandshake() (Security framework call) is called from
+// SSLClientSocketMac::DoHandshake().  Return value is -9812 (cert
+// valid but root not trusted), but if you don't have the cert in your
+// keychain as documented on
+// http://dev.chromium.org/developers/testing, the -9812 becomes a

[wtc, 2009/06/19 18:15:25]

This seems to imply that after importing the test root CA
into the keychain, we need to do something else to trust it.

+// -9813 (no root cert).
+//
+// See related handshake failures exhibited by disabled tests in
+// net/url_request/url_request_unittest.cc.
 #define MAYBE_Connect DISABLED_Connect
 #define MAYBE_ConnectExpired DISABLED_ConnectExpired
 #define MAYBE_ConnectMismatched DISABLED_ConnectMismatched
 #define MAYBE_Read DISABLED_Read
 #define MAYBE_Read_SmallChunks DISABLED_Read_SmallChunks
 #define MAYBE_Read_Interrupted DISABLED_Read_Interrupted
 #else
 #define MAYBE_Connect Connect
 #define MAYBE_ConnectExpired ConnectExpired
 #define MAYBE_ConnectMismatched ConnectMismatched
@@ skipping 282 matching lines @@
   // Do a partial read and then exit.  This test should not crash!
   scoped_refptr<net::IOBuffer> buf = new net::IOBuffer(512);
   rv = sock->Read(buf, 512, &callback);
   EXPECT_TRUE(rv >= 0 || rv == net::ERR_IO_PENDING);
 
   if (rv == net::ERR_IO_PENDING)
     rv = callback.WaitForResult();
 
   EXPECT_NE(rv, 0);
 }